Skip to content

Bump Static analysis tools#438

Merged
cortinico merged 1 commit into
developfrom
nc/bump-sa-tools
Aug 23, 2020
Merged

Bump Static analysis tools#438
cortinico merged 1 commit into
developfrom
nc/bump-sa-tools

Conversation

@cortinico

Copy link
Copy Markdown
Member

📄 Context

Bumped Detekt and KtLint to their latest stable version

📝 Changes

The diff is the output of ktlintFormat on the whole codebase

🛠️ How to test

Jobs will run on CI

@cortinico cortinico added the infra Issue or pull request relate to the library infrastructure (CI, Release mgmt, etc.) label Aug 23, 2020
@MiSikora MiSikora mentioned this pull request Aug 23, 2020
@vbuberen

Copy link
Copy Markdown
Collaborator

I hoped that Dependabot would do its job for these dependencies as well.
Looking forward to PRs from Dependabot for ConstraintLayout 2.0. If it doesn't open any till Friday, I will open such myself.

@cortinico

Copy link
Copy Markdown
Member Author

I hoped that Dependabot would do its job for these dependencies as well.

Yeah same here. However for ktlint we would have had to re-run the linter on the codebase to have a green CI so a PR was anyway necessary.

@cortinico cortinico merged commit e872b3e into develop Aug 23, 2020
@cortinico cortinico deleted the nc/bump-sa-tools branch August 23, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infra Issue or pull request relate to the library infrastructure (CI, Release mgmt, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants