Skip to content

Refactor viewmodels initialization to survive process death#368

Merged
vbuberen merged 2 commits into
developfrom
refactor/viewmodel
Jul 4, 2020
Merged

Refactor viewmodels initialization to survive process death#368
vbuberen merged 2 commits into
developfrom
refactor/viewmodel

Conversation

@vbuberen

Copy link
Copy Markdown
Collaborator

📄 Context

Due to how ViewModel objects were initialised Chucker had a bunch of crashes.
This PR changes the way Chucker works with ViewModels and resolves a bunch of issues:

📝 Changes

  • Updated to Fragment 1.2.5 to use latest extensions required.
  • Changed the declaration of ViewModel in Activity and Fragments.

🚫 Breaking

No issues found so far.

🛠️ How to test

For #364 follow the steps provided by @MiSikora
For #366 and #367 enable Don't keep activities and try to share some transaction as curl.

⏱️ Next steps

Add SavedStateHandle to save search query in TransactionListFragment and search query in updated TransactionPayloadFragment search (isn't published yet).

@vbuberen vbuberen added the bug Something isn't working label Jun 28, 2020
@vbuberen vbuberen added this to the 3.3.0 milestone Jun 28, 2020
@vbuberen vbuberen requested a review from cortinico June 28, 2020 12:58

@cortinico cortinico left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change @vbuberen 🚀
I've done several testing locally and seems like all works fine

@vbuberen vbuberen merged commit 6c6e7d9 into develop Jul 4, 2020
@vbuberen vbuberen deleted the refactor/viewmodel branch July 4, 2020 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

2 participants