Refactor viewmodels initialization to survive process death#368
Merged
Conversation
…y and its fragments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 Context
Due to how ViewModel objects were initialised Chucker had a bunch of crashes.
This PR changes the way Chucker works with ViewModels and resolves a bunch of issues:
📝 Changes
🚫 Breaking
No issues found so far.
🛠️ How to test
For #364 follow the steps provided by @MiSikora
For #366 and #367 enable
Don't keep activitiesand try to share some transaction as curl.⏱️ Next steps
Add
SavedStateHandleto save search query in TransactionListFragment and search query in updated TransactionPayloadFragment search (isn't published yet).