fix: remove unused wake lock permission#1498
Merged
Merged
Conversation
cortinico
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📷 Screenshots
No screenshots
📄 Context
Based on my code review, Chucker doesn't seem to need the Wake Lock Permission. Even the
ClearDatabaseServiceis a short-term task and doesn't require it.The permission's
maxSdkVersionof 25 is also a problem, as it can conflict with apps that use Chucker and declare their own Wake Lock, forcing them to override it. See #1077If this permission is truly necessary, I apologize for my misunderstanding and would appreciate an explanation of the necessity.
📝 Changes
Removed the wake lock permission from the library.
📎 Related PR
No related PR
🚫 Breaking
No breaking
🛠️ How to test
Normal testing is fine, but I suggest testing on API Level 25 and below to be sure.
⏱️ Next steps
No next steps