Skip to content

Forcing LTR in response payload Recycler View#1357

Merged
cortinico merged 1 commit into
ChuckerTeam:mainfrom
Younes-Charfaoui:fix-rtl-response
Jun 14, 2025
Merged

Forcing LTR in response payload Recycler View#1357
cortinico merged 1 commit into
ChuckerTeam:mainfrom
Younes-Charfaoui:fix-rtl-response

Conversation

@Younes-Charfaoui

@Younes-Charfaoui Younes-Charfaoui commented Apr 27, 2025

Copy link
Copy Markdown
Contributor

📷 Screenshots

After Change Before Change
After Change Before Change

📄 Context

Suppose you have an app that supports right-to-left (RTL) languages, such as Arabic. In that case, the chucker app will also be RTL, which can sometimes hinder the readability of the response, especially if it is a large JSON. You depend on indentation to locate certain values for debugging purposes or to confirm that specific values have been received. For that reason, I suggest this change.

📝 Changes

I have forced the layout direction of the RecyclerView to be LTR always.

🚫 Breaking

Nothing.

🛠️ How to test

Change the Sysmte language of the test device to arabic, then In the sample App, update the AndroidManifest.xml to include android:supportsRtl="true" in application tag, then try to launch some HTTP requests and verify the results that have some json, try this before and after applying the change in the PR.

⏱️ Next steps

Not sure, but the same should happen of the overview tab, but it is less critical than this one.

@Younes-Charfaoui Younes-Charfaoui requested a review from a team as a code owner April 27, 2025 22:13
@cortinico

Copy link
Copy Markdown
Member

Suppose you have an app that supports right-to-left (RTL) languages, such as Arabic. In that case, the chucker app will also be RTL, which can sometimes hinder the readability of the response, especially if it is a large JSON. You depend on indentation to locate certain values for debugging purposes or to confirm that specific values have been received. For that reason, I suggest this change.

That's a good point, but maybe the header section on top should still respect the RTL? I'm not a RTL native so I can't make a good call here.

@Younes-Charfaoui

Copy link
Copy Markdown
Contributor Author

Suppose you have an app that supports right-to-left (RTL) languages, such as Arabic. In that case, the chucker app will also be RTL, which can sometimes hinder the readability of the response, especially if it is a large JSON. You depend on indentation to locate certain values for debugging purposes or to confirm that specific values have been received. For that reason, I suggest this change.

That's a good point, but maybe the header section on top should still respect the RTL? I'm not a RTL native so I can't make a good call here.

It also doesn't help @cortinico. As a native Arabic speaker, it would only help if the information were in Arabic. Since it is in English, it makes sense to keep it in the same direction because it follows the key: value format, like date: 12/04/1997. It would help if it were 12/04/1997: تاريخ, but it isn’t, so it makes sense to have it as it is for all languages.

@cortinico cortinico left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the fix. Sorry for the late reivew @Younes-Charfaoui

@cortinico cortinico enabled auto-merge (squash) June 14, 2025 15:47
@cortinico cortinico merged commit f52f864 into ChuckerTeam:main Jun 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants