Skip to content

Implement support for select multiple request#1351

Merged
cortinico merged 6 commits into
ChuckerTeam:mainfrom
shivanandyadav11:feature_implement_share_multiple_request
Jun 14, 2025
Merged

Implement support for select multiple request#1351
cortinico merged 6 commits into
ChuckerTeam:mainfrom
shivanandyadav11:feature_implement_share_multiple_request

Conversation

@shivanandyadav11

@shivanandyadav11 shivanandyadav11 commented Apr 8, 2025 •
edited by cortinico
Loading

Copy link
Copy Markdown
Contributor

📷 Screenshots

Light Mode Dark Mode
Screenshot1 Screenshot2

Tested the flow - here is the testing video @cortinico

Chucker_multiple_selection.mov

📄 Context

Issue link: #1127

📝 Changes

  • Added multiple selection support in the transaction list.
  • Used ID-based selection tracking for accurate and stable selection state.
  • Applied selection highlight colour for both light and dark themes.

🛠️ How to test

  • Long-press any transaction to start selection mode.
  • Tap additional items to select/deselect them.
  • Verify selection highlight is applied using updated colour.
  • Tap a selected item to unselect it.

Closes #1130

@shivanandyadav11 shivanandyadav11 changed the title Implement support for select multiple request InProgress: Implement support for select multiple request Apr 8, 2025
@cortinico

cortinico commented Apr 8, 2025

Copy link
Copy Markdown
Member

Are you integrating #1130 into this?

@shivanandyadav11 shivanandyadav11 changed the title InProgress: Implement support for select multiple request Implement support for select multiple request Apr 8, 2025
@shivanandyadav11

shivanandyadav11 commented Apr 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Are you integrating #1130 into this?

@cortinico Yes, And it's ready now.

@shivanandyadav11 shivanandyadav11 marked this pull request as ready for review April 8, 2025 15:08
@shivanandyadav11 shivanandyadav11 requested a review from a team as a code owner April 8, 2025 15:08
@shivanandyadav11

shivanandyadav11 commented Apr 18, 2025

Copy link
Copy Markdown
Contributor Author

@cortinico Any update on this work ?
Do you have any suggestion/comments for this PR ?

@cortinico

cortinico commented Apr 19, 2025

Copy link
Copy Markdown
Member

@cortinico Any update on this work ?
Do you have any suggestion/comments for this PR ?

Sorry for the late reply. I'll review it next week just after Easter. I'd like to try it on my computer which I currently don't have with me

@cortinico

cortinico commented Apr 19, 2025

Copy link
Copy Markdown
Member

Also @shivanandyadav11 can you rebase and solve the conflict?

@shivanandyadav11 shivanandyadav11 force-pushed the feature_implement_share_multiple_request branch from 69cbe18 to 22a8e61 Compare April 20, 2025 04:53
@shivanandyadav11 shivanandyadav11 force-pushed the feature_implement_share_multiple_request branch from 22a8e61 to 90b295e Compare April 29, 2025 14:10
@shivanandyadav11

shivanandyadav11 commented Apr 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Also @shivanandyadav11 can you rebase and solve the conflict?

Rebased and conflict resolved.
Added Russian translations for newly added strings as well.
@cortinico Ready to merge.

shivanandyadav11
shivanandyadav11 commented Apr 29, 2025
View reviewed changes
Comment thread library/src/main/res/values-ru/strings.xml Outdated
@shivanandyadav11 shivanandyadav11 force-pushed the feature_implement_share_multiple_request branch from 7924261 to 9bf19da Compare April 29, 2025 15:26
@shivanandyadav11 shivanandyadav11 requested a review from Wreos April 29, 2025 15:27
@shivanandyadav11 shivanandyadav11 force-pushed the feature_implement_share_multiple_request branch 2 times, most recently from 2ed2360 to f098d53 Compare May 7, 2025 13:32
@shivanandyadav11 shivanandyadav11 force-pushed the feature_implement_share_multiple_request branch from f098d53 to 8b9d917 Compare May 8, 2025 17:11
@shivanandyadav11

shivanandyadav11 commented May 11, 2025

Copy link
Copy Markdown
Contributor Author

@cortinico Any Update on this ?

@cortinico

cortinico commented May 15, 2025

Copy link
Copy Markdown
Member

@cortinico Any Update on this ?

I'll be able to review this further next week. Sorry for the delay

@shivanandyadav11

shivanandyadav11 commented May 17, 2025

Copy link
Copy Markdown
Contributor Author

@cortinico Any Update on this ?

I'll be able to review this further next week. Sorry for the delay

Sounds like a nice plan, thanks for the update.

cortinico
cortinico approved these changes Jun 14, 2025
View reviewed changes

@cortinico cortinico left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the extremely late review @shivanandyadav11
I had a busy period those last months.

I tested your code, there was a problem with the string displayed when showing the share dialog to the user.

In order to move this forward, I've fixed it for you and I've enabled automerge on this one so it will be merged soon.

@cortinico cortinico enabled auto-merge (squash) June 14, 2025 16:13
@cortinico cortinico merged commit a8451c6 into ChuckerTeam:main Jun 14, 2025
6 of 8 checks passed
@shivanandyadav11 shivanandyadav11 deleted the feature_implement_share_multiple_request branch June 24, 2025 01:45
@shivanandyadav11 shivanandyadav11 mentioned this pull request Jul 8, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cortinico cortinico cortinico approved these changes

+1 more reviewer

@Wreos Wreos Wreos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shivanandyadav11 @cortinico @Wreos