Fix #1326: Move test dependency to test classpath#1327
Merged
Conversation
Contributor
Author
|
cc @irakliy01 did I read your intention right? Is this what you meant to do? |
cortinico
approved these changes
Dec 10, 2024
cortinico
left a comment
Member
There was a problem hiding this comment.
Thank you very much @TWiStErRob
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📷 Screenshots
None.
📄 Context
kotlinx-coroutines-testartifact on production classpath #1326📝 Changes
Move test dependency to test. How? Because
implementationis auto-exposed totestImplementation, so it worked before. Moving it to test directly should still work.📎 Related PR
🚫 Breaking
Removing a dependency is breaking change I guess, but since it was unintended it's not breaking?! idk 🤷🏻♂️
🛠️ How to test
CI Should test it, tests should pass.
⏱️ Next steps
Release 4.1.1