Disable notification permission request when showNotification is false#1165
Merged
cortinico merged 2 commits intoJan 26, 2024
Conversation
Member
|
@joakimtall can you update the CHANGELOG.md file as well? |
cortinico
approved these changes
Jan 25, 2024
cortinico
reviewed
Jan 25, 2024
Contributor
Author
Done! Thanks for early approval! But please take a look if the comment in Chucker.kt is what you had in mind |
Member
Yup thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal to fix #1164
Simply added field
showNotificationstoChuckerobject to pass this information to activity