Skip to content

Bug fix - Scroll to Search Navigation Bar Visibility Fix#1076

Merged
cortinico merged 2 commits into
ChuckerTeam:mainfrom
4shutosh:bugfix/scroll_to_search_fix
Jul 14, 2023
Merged

Bug fix - Scroll to Search Navigation Bar Visibility Fix#1076
cortinico merged 2 commits into
ChuckerTeam:mainfrom
4shutosh:bugfix/scroll_to_search_fix

Conversation

@4shutosh

Copy link
Copy Markdown
Contributor

📄 Context

Issue - Search for something on the response page, the search results are visible along with the nav bar, but when we append something to the query, that leads to zero search results, highlighting is reset, but the nav bar with old search results is still visible.

📎 Related PR

#988

🛠️ How to test

  • Search for a word available on the response page, and append something making it a query that won't have any results. the nav bar and the highlighted results should be reset.

@4shutosh 4shutosh requested a review from a team as a code owner July 13, 2023 11:18
@cortinico

Copy link
Copy Markdown
Member

but the nav bar with old search results is still visible.

Do you have a gif or a video of this bug?

@4shutosh

4shutosh commented Jul 14, 2023

Copy link
Copy Markdown
Contributor Author

Yes, this is the gif for the bug behaviour.

This is from the develop branch
ezgif com-resize

@cortinico cortinico left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cortinico cortinico added this to the 4.1.0 milestone Jul 14, 2023
@cortinico cortinico merged commit 99ab476 into ChuckerTeam:main Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants