Add chunking support to vectorize.table()#162
Conversation
|
@ChuckHend Have a look at your free time and kindly approve workflows, if any adjustments needed i am happy to incorporate them |
|
Waiting for a quick review on this too - @ChuckHend |
|
@ChuckHend Any changes needed here? |
|
I might need to provide further clarification in the issue. What is intended is that when calling |
|
@ChuckHend Updated the changes with intended approach of chunking Have a review on it and If any changes or modifications required I am ready to incorporate them |
|
@ChuckHend Have a review on it in your free time |
|
Can you add a test or two that shows how the functionality will work and assert that it functions as expected? |
|
Sure! I will update the tests |
|
Just a minor query just does we need automatic chunking once table is
called and it sync with chunk_table?
…On Mon, 4 Nov, 2024, 8:43 pm Adam Hendel, ***@***.***> wrote:
Can you add a test or two that shows how the functionality will work and
assert that it functions as expected?
—
Reply to this email directly, view it on GitHub
<#162 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BGXZB6GUWQYZTX2ZY75W7ATZ656JHAVCNFSM6AAAAABQEOKG32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJUHE3TOMBWGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Yes, let's leave the integration with |
|
Okay! |
|
@ChuckHend Any reviews on it |
|
Ill have this reviewed by end of week |
|
I haven't pushed my latest changes here which are in my local :) |
…into feat/chunk
|
@ChuckHend 👋 With this I think it's ready to merge |
extension/src/util.rs
Outdated
| } | ||
|
|
||
| /// Fetch rows from a given table and schema | ||
| pub async fn fetch_table_rows( |
There was a problem hiding this comment.
is this function being used anywhere?
There was a problem hiding this comment.
Nope! It used in previous approach, will remove it
Closes #142
/claim #142