Skip to content

chore: log read / write errors when persisting the telemetry state file#2016

Merged
yulunz merged 1 commit into
mainfrom
chore/log-file-persistence-errors
May 12, 2026
Merged

chore: log read / write errors when persisting the telemetry state file#2016
yulunz merged 1 commit into
mainfrom
chore/log-file-persistence-errors

Conversation

@yulunz

@yulunz yulunz commented May 8, 2026

Copy link
Copy Markdown
Collaborator

This adds logging to the read & write operations to the telemetry state file. In particular,

  • for read, no error is logged if the state file doesn't exist, which is expected to happen when the user is new. An error is logged otherwise (e.g. file format error, errors when reading an existing file like permission issue).
  • for write, any error in the path will be logged.

This commit also puts the instantiation of the Persistence object out of the ClearcutLogger object to avoid circular dependency.

@yulunz yulunz requested a review from OrKoN May 8, 2026 19:40
@yulunz yulunz force-pushed the chore/log-file-persistence-errors branch from cb5348d to 692c95e Compare May 12, 2026 19:00
@yulunz yulunz added this pull request to the merge queue May 12, 2026
Merged via the queue into main with commit 9a1ebc7 May 12, 2026
31 of 33 checks passed
@yulunz yulunz deleted the chore/log-file-persistence-errors branch May 12, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants