fix: centralize file path validation for tools#2150
Closed
msnandhis wants to merge 1 commit into
Closed
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
OrKoN
reviewed
May 28, 2026
| category: ToolCategory.DEBUGGING, | ||
| // Not read-only due to filePath param. | ||
| readOnlyHint: false, | ||
| filePathFields: [], |
Collaborator
There was a problem hiding this comment.
Thanks for the PR, we discussed it offline and we actually want to move filePathFields to the same level as blockedByDialog (i.e., outside of annotations). cc @Lightning00Blade
pull Bot
pushed a commit
to CrazyForks/chrome-devtools-mcp
that referenced
this pull request
May 28, 2026
|
Ok
Em qui., 28 de mai. de 2026 às 14:19, Nikolay Vitkov <
***@***.***> escreveu:
… Closed #2150
<#2150> via
#2152 <#2152>.
—
Reply to this email directly, view it on GitHub
<#2150?email_source=notifications&email_token=CDNASIODE2TOPDF7ILNZGFL45BYL7A5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTENRQG42DCMJWGI4DHJTSMVQXG33OVJZXKYTTMNZGSYTFMSSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#event-26074116283>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/CDNASIN7ZSZV3FBLTJXMWNL45BYL7AVCNFSM6AAAAACZQGV4X6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRWGA3TIMJRGYZDQMY>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/CDNASIM75W34N47VOABEUW345BYL7A5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTENRQG42DCMJWGI4DHJTSMVQXG33OVJZXKYTTMNZGSYTFMSSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/CDNASIPRNI5N3QEFOORF2ET45BYL7A5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTENRQG42DCMJWGI4DHJTSMVQXG33OVJZXKYTTMNZGSYTFMSSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you are subscribed to this thread.Message
ID: <ChromeDevTools/chrome-devtools-mcp/pull/2150/issue_event/26074116283@
github.com>
|
samiyac
pushed a commit
to bcfmtolgahan/chrome-devtools-mcp
that referenced
this pull request
Jun 5, 2026
pull Bot
pushed a commit
to CrazyForks/chrome-devtools-mcp
that referenced
this pull request
Jun 8, 2026
🤖 I have created a release *beep* *boop* --- ## [1.2.0](ChromeDevTools/chrome-devtools-mcp@chrome-devtools-mcp-v1.1.1...chrome-devtools-mcp-v1.2.0) (2026-06-08) ### 🎉 Features * add experimental TOON support for structured content output ([ChromeDevTools#2042](ChromeDevTools#2042)) ([aa33bff](ChromeDevTools@aa33bff)) * Adds close_heapsnapshot MCP tool ([ChromeDevTools#2174](ChromeDevTools#2174)) ([8713b93](ChromeDevTools@8713b93)) * Handle multiple providers of third-party developer tools ([ChromeDevTools#2168](ChromeDevTools#2168)) ([30d59a7](ChromeDevTools@30d59a7)) * implement extension service worker logs ([ChromeDevTools#1915](ChromeDevTools#1915)) ([29e3898](ChromeDevTools@29e3898)) * memory debugging tools ([ChromeDevTools#2169](ChromeDevTools#2169)) ([0217397](ChromeDevTools@0217397)) * support allowedUrlPattern & blockedUrlPattern Options ([ChromeDevTools#2037](ChromeDevTools#2037)) ([02b4492](ChromeDevTools@02b4492)) ### 🛠️ Fixes * Cursor plugin homepage setting field ([ChromeDevTools#2173](ChromeDevTools#2173)) ([8971890](ChromeDevTools@8971890)) ### 📄 Documentation * **skill:** guide agent to prompt for --categoryExtensions ([ChromeDevTools#2189](ChromeDevTools#2189)) ([8b458f7](ChromeDevTools@8b458f7)) ### ⚡ Performance * lighthouse file saves to run concurrently ([ChromeDevTools#2178](ChromeDevTools#2178)) ([f90f863](ChromeDevTools@f90f863)) ### 🏗️ Refactor * change type of logger ([ChromeDevTools#2165](ChromeDevTools#2165)) ([bf0574d](ChromeDevTools@bf0574d)) * use validate files on the tool level ([ChromeDevTools#2152](ChromeDevTools#2152)) ([2e039c0](ChromeDevTools@2e039c0)), closes [ChromeDevTools#2150](ChromeDevTools#2150) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2138.
Summary
This centralizes workspace-root validation for request file path fields instead of having individual tool handlers call
context.validatePath(...)directly.Changes included:
annotations.filePathFieldsmetadata to tool definitionsToolHandlerbefore handler executionfilePath,requestFilePath,responseFilePath,outputDirPath, and extensionpathreload_extension, because that path is resolved from existing extension state rather than from request paramsToolHandlercoverage to ensure annotated file path fields are validated before the handler runsTesting
npm run formatnpm run check-formatnpm run test tests/ToolHandler.test.tsI also started a full
npm run test; it built and ran many tests locally, then remained quiet in a daemon/browser section, so I stopped the local run and cleaned up the spawned daemon processes rather than leaving them running.