Skip to content

Removed skipping of CountOnNull rector rule.#189

Merged
markdorison merged 2 commits into4.xfrom
remove-count-on-null-skip
Dec 7, 2023
Merged

Removed skipping of CountOnNull rector rule.#189
markdorison merged 2 commits into4.xfrom
remove-count-on-null-skip

Conversation

@markdorison
Copy link
Copy Markdown
Contributor

Description

Removed skipping of CountOnNull rector rule.

Fixed upstream: rectorphp/rector-src#4556

Motivation / Context

Tests were failing because the upstream fix resolved the issue.

Testing Instructions / How This Has Been Tested

Tests should pass.

@markdorison markdorison self-assigned this Dec 7, 2023
@markdorison markdorison added backport 3.x will automatically create backport PR to the 3.x branch when merged backport 2.x will automatically create backport PR to the 2.x branch when merged labels Dec 7, 2023
@ghost
Copy link
Copy Markdown

ghost commented Dec 7, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@markdorison markdorison merged commit c7b7b5e into 4.x Dec 7, 2023
@markdorison markdorison deleted the remove-count-on-null-skip branch December 7, 2023 15:52
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 7, 2023

Successfully created backport PR for 2.x:

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 7, 2023

Successfully created backport PR for 3.x:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x will automatically create backport PR to the 2.x branch when merged backport 3.x will automatically create backport PR to the 3.x branch when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant