Fix Excluding Logic for Preprocessor #2813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit should fix issue ChrisTitusTech#2795 reported by @CodingWonders
Contributor
|
@og-mrk, I've tested your change and it works fine on PowerShell 5 |
CodingWonders
approved these changes
Sep 24, 2024
MyDrift-user
approved these changes
Sep 24, 2024
ruxunderscore
approved these changes
Sep 24, 2024
Contributor
There was a problem hiding this comment.
Tested, on my end. Don't see the same error I had before my -Force "fix", so this rewrite was definitely needed. Since, this also fixes @CodingWonders problems with compiling in Powershell 5, then I say this is amazing. This kind of rewrite was something I planned on doing. Thanks!
12 tasks
ChrisTitusTech
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR should fix issue #2795 reported by @CodingWonders
Testing
Compiled WinUtil successfully in both PowerShell 5 & 7, and the main issue of
.gitgetting corrupted by the preprocessor shouldn't happen again.Impact
This won't impact End-Users, but the Developers who work on WinUtil (to be specific, devs who work in PowerShell 5 environment, which we're currently supporting with PowerShell 7).
Issue related to PR
.gitfolder in PowerShell 5 #2795Additional Information
This was reported first by @CodingWonders on WinUtil Community Discord, so thanks again for notifying me (and others) about this issue 😄.
Also, I do realize that the preprocessor is very slow at the moment ( considering it doesn't do that complex of a task :/ ), will try to optimize / make it feature complete in the future, but for the time being.. my bad for wasting your time in compile times 🙃.
Checklist