Fix for Geyser HBox/VBox with width/height at 0 (Mudlet#3909)

Edru2 · web-flow · commit a7dc3a22d292 · 2020-06-15T21:51:39.000+02:00
* prevent height/width of 0

* better solution still keeps hbox at 0

* small correction
diff --git a/src/mudlet-lua/lua/geyser/GeyserHBox.lua b/src/mudlet-lua/lua/geyser/GeyserHBox.lua
@@ -26,6 +26,13 @@ end
 -- Called when a new element is added
 function Geyser.HBox:organize()
   self.parent:reposition()
+  -- Workaround for issue with width/height being 0 at creation
+  if self:get_width() == 0 then
+    self:resize("0.9px", nil)
+  end
+  if self:get_height() == 0 then
+    self:resize(nil, "0.9px")
+  end
   local window_width = (self:calculate_dynamic_window_size().width / self:get_width()) * 100
   local start_x = 0
   for _, window_name in ipairs(self.windows) do
@@ -40,7 +47,7 @@ function Geyser.HBox:organize()
       height = 100
     end
     window:resize(width.."%", height.."%")
-    start_x = start_x + (window:get_width() / self:get_width()) * 100
+    start_x = start_x + width
   end
 end
 
@@ -65,12 +72,4 @@ function Geyser.HBox:new2 (cons, container)
   cons.useAdd2 = true
   local me = self:new(cons, container)
   return me
-end
-
---- Overridden constructor to use add2
-function Geyser.HBox:new2 (cons, container)
-  cons = cons or {}
-  cons.useAdd2 = true
-  local me = self:new(cons, container)
-  return me
-end
+end
diff --git a/src/mudlet-lua/lua/geyser/GeyserVBox.lua b/src/mudlet-lua/lua/geyser/GeyserVBox.lua
@@ -27,8 +27,14 @@ end
 -- Called when a new element is added
 function Geyser.VBox:organize()
   self.parent:reposition()
-
-  local window_height = (self:calculate_dynamic_window_size().height / self.get_height()) * 100
+  -- Workaround for issue with width/height being 0 at creation
+  if self:get_width() == 0 then
+    self:resize("0.9px", nil)
+  end
+  if self:get_height() == 0 then
+    self:resize(nil, "0.9px")
+  end
+  local window_height = (self:calculate_dynamic_window_size().height / self:get_height()) * 100
   local start_y = 0
   for _, window_name in ipairs(self.windows) do
     local window = self.windowList[window_name]
@@ -42,7 +48,7 @@ function Geyser.VBox:organize()
       height = window_height * window.v_stretch_factor
     end
     window:resize(width.."%", height.."%")
-    start_y = start_y + (window:get_height() / self:get_height()) * 100
+    start_y = start_y + height
   end
 end
 
@@ -66,4 +72,4 @@ function Geyser.VBox:new2 (cons, container)
   cons.useAdd2 = true
   local me = self:new(cons, container)
   return me
-end
+end
