fix(CI): increase faucet funding timeout from 5 to 10 minutes#1569
Merged
Conversation
Testnet transaction confirmation latency caused the v1-to-v2 upgrade test to timeout waiting for wallet funding. All 8 jobs got identical HTTP 202 faucet responses, but confirmation times ranged from ~3 to 5+ minutes. Bump MAX_ATTEMPTS from 30 to 60 (10 minutes) across all 8 wallet funding polling loops to absorb testnet variability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
In run #2427, the
v1 to v2 upgrade testfailed because the faucet-funded transaction didn't confirm within 5 minutes. All 8 jobs received identical HTTP 202 faucet responses on the first attempt, but testnet confirmation times ranged from ~3 to 5+ minutes — thev2 governancejob barely made it at attempt 27 (~5m14s), and the upgrade test timed out at attempt 30.Test plan
Note
Low Risk
Low risk CI-only change that just increases the wait window for testnet faucet funding; main impact is potentially longer CI runtime on slow confirmations.
Overview
Improves CI resilience to slow testnet confirmations by doubling the faucet-funding balance polling window from 30 to 60 attempts (5m → 10m) across the workflow’s faucet-funded jobs.
Updates the corresponding timeout error messages to reflect the new 10-minute limit.
Reviewed by Cursor Bugbot for commit a0b7fad. Bugbot is set up for automated code reviews on this repo. Configure here.