revert(CI): restore auto-release tag creation, remove release-please#1568
Merged
Merged
Conversation
The auto-release workflow's primary purpose is to compare the version in package.json to existing tags and create a tag + changelog when the version is new. PR #1567 removed this core functionality in favor of release-please-action, which adds an unnecessary external dependency. The original approach using npx conventional-changelog-cli works fine and doesn't require any project devDependencies (npx downloads it on-the-fly in CI). The commit-and-tag-version devDep removal from #1567 is intentionally kept since the auto-release workflow never used it — it only resolves the handlebars vulnerability from #1562. Reverts: auto-release.yml changes from #1567 Removes: release-please.yml, release-please-config.json, .release-please-manifest.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auto-release.ymlto its original functionality: compare the version inpackage.jsonto tags and create a tag + changelog when the version is new (reverts the workflow changes from chore(CI): migrate from standard-version to release-please #1567)release-please.yml,release-please-config.json, and.release-please-manifest.json— avoids introducinggoogleapis/release-please-actionas a new external dependencycommit-and-tag-versiondevDependency removal from chore(CI): migrate from standard-version to release-please #1567 since the auto-release workflow never used it (it usesnpx conventional-changelog-cliwhich is downloaded on-the-fly in CI), and that removal resolves thehandlebarsvulnerability from chore(deps-dev): bump handlebars from 4.7.8 to 4.7.9 #1562Why
The core purpose of the auto-release job is to detect when
package.jsonhas a version that doesn't yet have a corresponding git tag, then generate the changelog and create the tag — which triggers the downstream build workflow. PR #1567 removed this functionality in favor ofrelease-please-action, but the originalnpx conventional-changelog-cliapproach works without any project devDependencies and without adding a new GitHub Actions dependency.Test plan
release-please.yml,release-please-config.json, and.release-please-manifest.jsonare removedNote
Medium Risk
Moderate risk because it changes the release automation path (tagging/changelog generation and pushes to
main), which can impact how and when releases are cut; no runtime application code is touched.Overview
Restores the
auto-release.ymlworkflow to auto-create a git tag and regenerateCHANGELOG.mdwhenpackage.json’s version has no matching tag, then pushes the tag (and the changelog commit) to trigger the existing tag-based release pipeline.Removes the
release-pleasesetup (.github/workflows/release-please.yml,release-please-config.json,.release-please-manifest.json), reverting away fromgoogleapis/release-please-actionand keeping dependency updates ondevelopas part of the post-release workflow.Reviewed by Cursor Bugbot for commit 010c734. Bugbot is set up for automated code reviews on this repo. Configure here.