Skip to content

fix: add file_store mirror to periodic mirror check#1496

Merged
TheLastCicada merged 1 commit into
v2-rc2from
fix/mirror-check-file-store
Feb 13, 2026
Merged

fix: add file_store mirror to periodic mirror check#1496
TheLastCicada merged 1 commit into
v2-rc2from
fix/mirror-check-file-store

Conversation

@TheLastCicada

Copy link
Copy Markdown
Contributor

Summary

  • The periodic mirror check task (mirror-check.js / mirror-check-v2.js) ensures mirrors exist for org_uid, registry_id, and data_model_version_store_id stores, but was missing the file_store entirely
  • When the initial mirror creation during org creation fails (e.g., wallet temporarily unsynced), the file_store mirror was never retried by the periodic task, causing the CI test's organization mirror validation to fail
  • Added file_store mirror creation to both V1 and V2 mirror check tasks so it is retried on the periodic schedule like all other org stores

Root Cause Analysis

From CI run #22002605727:

  1. During org creation at 21:11:53, the add_mirror RPC call for the file_store (3a8b8ee6...) failed with "Wallet needs to be fully synced before making transactions"
  2. After org creation completed, runMirrorCheckV2() was triggered at 21:14:24 to retry any failed mirrors
  3. The mirror check successfully created/verified mirrors for org_uid, registry_id, and data_model_version_store_id
  4. But it never attempted the file_store mirror because the code simply didn't include it
  5. Test validation found 0 mirrors for the file_store and failed

Test plan

  • Re-run the v2 live API tests to verify the file_store mirror is created by the periodic mirror check
  • Verify the V1 mirror check also handles fileStoreId correctly

The mirror check task ensures mirrors exist for org_uid, registry_id,
and data_model_version_store_id but was missing the file_store. When
the initial mirror creation during org creation fails (e.g. wallet
temporarily unsynced), the file_store mirror was never retried.

Add file_store mirror creation to both V1 and V2 mirror check tasks
so it is retried on the periodic schedule like all other stores.
@TheLastCicada TheLastCicada merged commit 35c58b8 into v2-rc2 Feb 13, 2026
13 of 15 checks passed
@TheLastCicada TheLastCicada deleted the fix/mirror-check-file-store branch February 13, 2026 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant