fix: add file_store mirror to periodic mirror check#1496
Merged
Conversation
The mirror check task ensures mirrors exist for org_uid, registry_id, and data_model_version_store_id but was missing the file_store. When the initial mirror creation during org creation fails (e.g. wallet temporarily unsynced), the file_store mirror was never retried. Add file_store mirror creation to both V1 and V2 mirror check tasks so it is retried on the periodic schedule like all other stores.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mirror-check.js/mirror-check-v2.js) ensures mirrors exist fororg_uid,registry_id, anddata_model_version_store_idstores, but was missing thefile_storeentirelyRoot Cause Analysis
From CI run #22002605727:
add_mirrorRPC call for the file_store (3a8b8ee6...) failed with "Wallet needs to be fully synced before making transactions"runMirrorCheckV2()was triggered at 21:14:24 to retry any failed mirrorsorg_uid,registry_id, anddata_model_version_store_idTest plan
fileStoreIdcorrectly