fix(V2): use correct mirror DB name in test verification helper#1495
Merged
Conversation
The mysql-mirror-helpers.js test helper was appending '_v2' to the DB_NAME from config, but the CADT application uses DB_NAME as-is. This caused mirror verification to check an empty database instead of the one CADT actually writes to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mysql-mirror-helpers.jstest helper was incorrectly appending_v2to theDB_NAMEfrom config (e.g.,cadt_mirror_testbecamecadt_mirror_test_v2)DB_NAMEas-is for the V2 mirror database, so the test was verifying against an empty/nonexistent databaseRoot Cause
config.jsv2Mirror)cadt_mirror_test(rawDB_NAME)prepareV2Db)cadt_mirror_test(creates and migrates this)cadt_mirror_test_v2(DB_NAME+_v2)Fix
Removed the
_v2suffix inmysql-mirror-helpers.jsso the test verification connects to the same database that CADT actually writes to.Test plan