fix(TEST): trim test-config.yaml to overrides-only and fix defaultConfig mutation

TheLastCicada · TheLastCicada · commit f625c950ceb6 · 2026-05-06T14:38:08.000-07:00
test-config.yaml now specifies only values that differ from
defaultConfig.js; all other values are filled via mergeObjects at load
time.  This uncovered two latent bugs:

1. enable-disable-versions.spec.js used shallow spread on defaultConfig
   then mutated nested V1/V2.ENABLE, permanently corrupting the
   in-memory defaults for subsequent tests.  Fixed with deep copy.

2. withConfigOverride assumed currentConfig.V1 always existed in the
   legacy-override branch.  Added null guard.
diff --git a/tests/v2/config/test-config.yaml b/tests/v2/config/test-config.yaml
@@ -1,55 +1,7 @@
 APP:
-  CW_PORT: 31310
-  BIND_ADDRESS: localhost
-  DATALAYER_URL: https://localhost:8562
-  WALLET_URL: https://localhost:9256
   USE_SIMULATOR: true
-  CHIA_NETWORK: mainnet
-  USE_DEVELOPMENT_MODE: false
-  DEFAULT_FEE: 3000
-  DEFAULT_COIN_AMOUNT: 300
-  CERTIFICATE_FOLDER_PATH: null
-  DATALAYER_FILE_SERVER_URL: null
-  AUTO_SUBSCRIBE_FILESTORE: false
-  AUTO_MIRROR_EXTERNAL_STORES: true
-  LOG_LEVEL: info
   TASKS:
-    GOVERNANCE_SYNC_TASK_INTERVAL: 30
-    DEFAULT_ORGANIZATIONS_SYNC_TASK_INTERVAL: 30
-    ORGANIZATION_META_SYNC_TASK_INTERVAL: 300
-    PICKLIST_SYNC_TASK_INTERVAL: 30
     MIRROR_CHECK_TASK_INTERVAL: 86460
-    VALIDATE_ORGANIZATION_TABLE_TASK_INTERVAL: 1800
-  REQUEST_CONTENT_LIMITS:
-    STAGING:
-      EDIT_DATA_LEN: 200
-    UNITS:
-      INCLUDE_COLUMNS_LEN: 200
-      MARKETPLACE_IDENTIFIERS_LEN: 200
-    PROJECTS:
-      INCLUDE_COLUMNS_LEN: 200
-      PROJECT_IDS_LEN: 200
-V1:
-  ENABLE: true
-  READ_ONLY: false
-  CADT_API_KEY: null
-  IS_GOVERNANCE_BODY: false
-  GOVERNANCE:
-    GOVERNANCE_BODY_ID: 23f6498e015ebcd7190c97df30c032de8deb5c8934fc1caa928bc310e2b8a57e
-  MIRROR_DB:
-    DB_USERNAME: null
-    DB_PASSWORD: null
-    DB_NAME: null
-    DB_HOST: null
 V2:
-  ENABLE: true
-  READ_ONLY: false
-  CADT_API_KEY: null
-  IS_GOVERNANCE_BODY: false
   GOVERNANCE:
     GOVERNANCE_BODY_ID: ''
-  MIRROR_DB:
-    DB_USERNAME: null
-    DB_PASSWORD: null
-    DB_NAME: null
-    DB_HOST: null
diff --git a/tests/v2/integration/enable-disable-versions.spec.js b/tests/v2/integration/enable-disable-versions.spec.js
@@ -64,7 +64,7 @@ describe('V1/V2 Enable/Disable Functionality Tests', function () {
 
   // Helper function to write unified config
   const writeUnifiedConfig = (v1Enable, v2Enable) => {
-    const testConfig = { ...defaultConfig };
+    const testConfig = JSON.parse(JSON.stringify(defaultConfig));
     testConfig.V1.ENABLE = v1Enable;
     testConfig.V2.ENABLE = v2Enable;
     // Ensure directory exists
@@ -158,7 +158,7 @@ describe('V1/V2 Enable/Disable Functionality Tests', function () {
     });
 
     it('should respect ENABLE: false in V1 config', function () {
-      const testConfig = { ...defaultConfig };
+      const testConfig = JSON.parse(JSON.stringify(defaultConfig));
       testConfig.V1.ENABLE = false;
       const configDir = path.dirname(unifiedConfigPath);
       if (!fs.existsSync(configDir)) {
@@ -173,7 +173,7 @@ describe('V1/V2 Enable/Disable Functionality Tests', function () {
     });
 
     it('should respect ENABLE: false in V2 config', function () {
-      const testConfig = { ...defaultConfig };
+      const testConfig = JSON.parse(JSON.stringify(defaultConfig));
       testConfig.V2.ENABLE = false;
       const configDir = path.dirname(unifiedConfigPath);
       if (!fs.existsSync(configDir)) {
diff --git a/tests/v2/utils/v2-test-helpers.js b/tests/v2/utils/v2-test-helpers.js
@@ -619,6 +619,9 @@ export const withConfigOverride = async (testFn, configOverrides) => {
         // Legacy support: if override keys don't match sections, merge into V1
         // This handles old-style overrides like { GOVERNANCE: { ... }, MIRROR_DB: { ... } }
         // These are V1-specific sections
+        if (!currentConfig.V1) {
+          currentConfig.V1 = {};
+        }
         if (!currentConfig.V1[section]) {
           currentConfig.V1[section] = {};
         }
