fix: compare task intervals numerically in diagnostics

TheLastCicada · TheLastCicada · commit f31612fc945f · 2026-06-08T12:03:16.000-07:00
docker-entrypoint.sh writes env-provided APP.TASKS intervals back to
config.yaml as quoted YAML strings, so a value equal to the numeric
shipped default (e.g. "120" vs 120) was reported as drift by
collectNonDefaultTaskIntervals. Compare numerically when both sides
parse as finite numbers, falling back to strict equality otherwise.
diff --git a/src/routes/diagnostics.js b/src/routes/diagnostics.js
@@ -363,7 +363,18 @@ const collectNonDefaultTaskIntervals = (actualTasks, defaultTasks = defaultConfi
   for (const key of TASK_INTERVAL_KEYS) {
     const defaultValue = defaultTasks?.[key];
     const actualValue = actualTasks?.[key];
-    if (actualValue === undefined || actualValue === defaultValue) continue;
+    if (actualValue === undefined) continue;
+    // docker-entrypoint.sh writes env-provided intervals back as quoted YAML
+    // strings, so a config value can equal the numeric default semantically
+    // ("120" vs 120). Compare numerically when both parse as finite numbers,
+    // falling back to strict equality otherwise.
+    const defaultNum = Number(defaultValue);
+    const actualNum = Number(actualValue);
+    const isEqual =
+      Number.isFinite(defaultNum) && Number.isFinite(actualNum)
+        ? defaultNum === actualNum
+        : actualValue === defaultValue;
+    if (isEqual) continue;
     nonDefault.push({ key, default: defaultValue, actual: actualValue });
   }
   return nonDefault;
diff --git a/tests/v2/integration/diagnostics-helpers.spec.js b/tests/v2/integration/diagnostics-helpers.spec.js
@@ -625,4 +625,21 @@ describe('diagnostics collectNonDefaultTaskIntervals', function () {
     };
     expect(collectNonDefaultTaskIntervals(actual, defaultTasks)).to.deep.equal([]);
   });
+
+  it('treats numeric-string intervals equal to the default as default', function () {
+    // docker-entrypoint.sh writes env-provided intervals as quoted YAML strings.
+    const actual = {
+      ...defaultTasks,
+      GOVERNANCE_SYNC_TASK_INTERVAL: '120',
+      MIRROR_CHECK_TASK_INTERVAL: '900',
+    };
+    expect(collectNonDefaultTaskIntervals(actual, defaultTasks)).to.deep.equal([]);
+  });
+
+  it('still reports numeric-string intervals that differ from the default', function () {
+    const actual = { ...defaultTasks, PICKLIST_SYNC_TASK_INTERVAL: '60' };
+    expect(collectNonDefaultTaskIntervals(actual, defaultTasks)).to.deep.equal([
+      { key: 'PICKLIST_SYNC_TASK_INTERVAL', default: 120, actual: '60' },
+    ]);
+  });
 });
