fix(V2): exclude cross-ref FKs from join table ownership resolution

TheLastCicada · TheLastCicada · commit dd28d78c1484 · 2026-05-28T09:58:50.000-07:00
Join tables (project_methodology, stakeholder_projects, unit_label)
reference entities owned by different organizations. The ownership
guard was following all parent FKs, collecting non-home org UIDs from
the referenced side, and blocking legitimate deletes/cascade deletes.

Only follow the owning-side FK for ownership resolution on these
tables while leaving non-join table behavior unchanged.
diff --git a/src/models/v2/staging-v2.model.js b/src/models/v2/staging-v2.model.js
@@ -158,6 +158,25 @@ class StagingV2 extends Model {
     };
   }
 
+  static getJoinTableOwnershipFks() {
+    return {
+      project_methodology: new Set(['cadTrustProjectId']),
+      stakeholder_projects: new Set(['cadTrustProjectId']),
+      unit_label: new Set(['cadTrustUnitId']),
+    };
+  }
+
+  static getExcludedFieldsForTable(table) {
+    const ownershipFks = StagingV2.getJoinTableOwnershipFks()[table];
+    if (!ownershipFks) return new Set();
+
+    return new Set(
+      StagingV2.getOwnershipParentModels()
+        .map(([fieldName]) => fieldName)
+        .filter((f) => !ownershipFks.has(f)),
+    );
+  }
+
   static getOwnershipParentModels() {
     return [
       ['cadTrustProjectId', ProjectV2],
@@ -311,8 +330,11 @@ class StagingV2 extends Model {
         : null;
 
       if (existingRecord) {
+        const tableExcludedFields = StagingV2.getExcludedFieldsForTable(values.table);
         await StagingV2.assertOwnerOrgUidsAreHome(
-          await StagingV2.collectOwnerOrgUids(existingRecord, options),
+          await StagingV2.collectOwnerOrgUids(
+            existingRecord, options, new Set(), 0, false, [], tableExcludedFields,
+          ),
           values.table,
           true,
         );
@@ -332,6 +354,8 @@ class StagingV2 extends Model {
           );
         }
 
+        const updateExcluded = StagingV2.getExcludedFieldsForTable(values.table);
+        updateExcluded.add(primaryKeyApiField);
         await StagingV2.assertOwnerOrgUidsAreHome(
           await StagingV2.collectOwnerOrgUids(
             recordData,
@@ -340,7 +364,7 @@ class StagingV2 extends Model {
             0,
             true,
             unresolvedFields,
-            new Set([primaryKeyApiField]),
+            updateExcluded,
           ),
           values.table,
           payloadHasOwnershipFields,
