fix: protect transaction rollback so mirror rollback is always reached

TheLastCicada · TheLastCicada · commit d0c15a2b6be8 · 2026-05-06T15:19:46.000-07:00
If transaction.rollback() throws, mirrorTransaction.rollback() was
never reached, leaking the mirror connection. Wrap both rollbacks in
independent try-catch blocks.
diff --git a/src/tasks/sync-registries.js b/src/tasks/sync-registries.js
@@ -253,12 +253,15 @@ async function createAndProcessTransaction(callback, afterCommitCallbacks) {
 
     return true;
   } catch (error) {
-    // Roll back the transaction if an error occurs
+    logger.error(
+      `encountered error syncing organization audit. Rolling back transaction. Error: ${error}`,
+    );
     if (transaction) {
-      logger.error(
-        `encountered error syncing organization audit. Rolling back transaction. Error: ${error}`,
-      );
-      await transaction.rollback();
+      try {
+        await transaction.rollback();
+      } catch (rollbackErr) {
+        logger.error(`transaction rollback failed: ${rollbackErr.message}`);
+      }
     }
     if (mirrorTransaction) {
       try {
