fix(V2): address pre-push review findings

TheLastCicada · TheLastCicada · commit c1073d16904e · 2026-04-24T11:45:04.000-07:00
- Harden hasStagedDelete to check all diff.change elements, not just
  parsed[0], guarding against before/after array payloads
- Assert non-deleted Graph B siblings survive after cascade commit to
  detect overly-aggressive cascades
- Correct COMMIT_POLL_INTERVAL_MS comment: interval affects both live
  jobs and the per-iteration load is ~6.7x (two HTTP calls per loop),
  not ~3x
- Annotate org-creation polling loops to explain why they intentionally
  do not use COMMIT_POLL_INTERVAL_MS
diff --git a/tests/v2/live-api/cascade-delete.live.spec.js b/tests/v2/live-api/cascade-delete.live.spec.js
@@ -48,7 +48,7 @@ describe('Cascade Delete Live API Tests', function () {
     }
     const data = row.diff?.change;
     const parsed = Array.isArray(data) ? data : [data];
-    return parsed[0]?.[key] === value;
+    return parsed.some((p) => p?.[key] === value);
   });
 
   it('should cascade delete project and sub-entity children through commit', async function () {
@@ -214,5 +214,20 @@ describe('Cascade Delete Live API Tests', function () {
       const resp = await request.get(`${endpoint}/${id}`);
       expect([400, 404]).to.include(resp.status);
     }
+
+    // Verify non-deleted Graph B siblings are still present (guards against
+    // overly-aggressive cascades that silently delete sibling entities)
+    const survivingGraphB = [
+      ['/v2/project', projectBId],
+      ['/v2/project-methodology', pm1Id],
+      ['/v2/verification', ver2Id],
+      ['/v2/verification', ver3Id],
+      ['/v2/issuance', iss3Id],
+    ];
+
+    for (const [endpoint, id] of survivingGraphB) {
+      const resp = await request.get(`${endpoint}/${id}`);
+      expect(resp.status, `expected ${endpoint}/${id} to still exist after cascade`).to.equal(200);
+    }
   });
 });
diff --git a/tests/v2/live-api/helpers/live-api-helpers.js b/tests/v2/live-api/helpers/live-api-helpers.js
@@ -11,7 +11,10 @@ import {
 } from './wallet-diagnostics.js';
 
 // Reduced from 10 000 ms to cut idle wait time between blockchain commits.
-// Increases API call volume ~3x but stays well within the 30-minute suite timeout.
+// Each iteration calls two HTTP endpoints (org-synced + wallet-diagnostics),
+// so the total request rate increase across all live jobs is ~6.7× vs the old
+// 10 s interval.  Both jobs (test-v2-live-api, test-v2-live-cascade-delete)
+// use this helper; the 30-minute suite timeout is not at risk.
 const COMMIT_POLL_INTERVAL_MS = 3000;
 
 /**
@@ -1199,7 +1202,7 @@ export const getLiveApiRequest = async (options = {}) => {
 export const waitForV2OrganizationReady = async (request, orgName = null, maxWaitTime = 900000, options = {}) => {
   const { isUpgrade = false } = options;
   const startTime = Date.now();
-  const interval = 10000;
+  const interval = 10000; // org-creation poller, not a commit poller — intentionally not COMMIT_POLL_INTERVAL_MS
   const timestamp = getTimestamp();
   const recoveryTracker = createRecoveryStuckTracker();
   let lastDiagAt = 0;
@@ -1496,7 +1499,7 @@ export const waitForV2OrganizationReady = async (request, orgName = null, maxWai
  */
 export const waitForV1OrganizationReady = async (request, orgName = null, maxWaitTime = 900000) => {
   const startTime = Date.now();
-  const interval = 10000;
+  const interval = 10000; // org-creation poller, not a commit poller — intentionally not COMMIT_POLL_INTERVAL_MS
   const timestamp = getTimestamp();
   const recoveryTracker = createRecoveryStuckTracker();
   let lastDiagAt = 0;
