fix: handle MySQL mirror connection failure gracefully in v1 prepareDb

TheLastCicada · TheLastCicada · commit c0eb64fbee58 · 2026-04-10T12:08:34.000-07:00
V1's prepareDb() crashed with ECONNREFUSED when the MySQL mirror sidecar
wasn't ready, causing the entire CADT process to exit. V2's prepareV2Db()
already handled this gracefully with a try-catch. This aligns V1 with
V2's behavior: log the error and continue with the main SQLite database.
The mirror will reconnect on the next sync cycle via safeMirrorDbHandler.

Also adds the missing connection.end() call in a finally block to
prevent connection leaks on any failure path.
diff --git a/src/database/index.js b/src/database/index.js
@@ -165,20 +165,29 @@ export const prepareDb = async () => {
     getConfig().MIRROR_DB.DB_HOST &&
     getConfig().MIRROR_DB.DB_HOST !== ''
   ) {
-    const connection = await mysql.createConnection({
-      host: getConfig().MIRROR_DB.DB_HOST,
-      port: 3306,
-      user: getConfig().MIRROR_DB.DB_USERNAME,
-      password: getConfig().MIRROR_DB.DB_PASSWORD,
-    });
+    try {
+      const connection = await mysql.createConnection({
+        host: getConfig().MIRROR_DB.DB_HOST,
+        port: 3306,
+        user: getConfig().MIRROR_DB.DB_USERNAME,
+        password: getConfig().MIRROR_DB.DB_PASSWORD,
+      });
 
-    await connection.query(
-      `CREATE DATABASE IF NOT EXISTS \`${getConfig().MIRROR_DB.DB_NAME}\`;`,
-    );
+      try {
+        await connection.query(
+          `CREATE DATABASE IF NOT EXISTS \`${getConfig().MIRROR_DB.DB_NAME}\`;`,
+        );
+      } finally {
+        await connection.end();
+      }
 
-    const db = new Sequelize(config[mirrorConfig]);
+      const db = new Sequelize(config[mirrorConfig]);
 
-    await checkForMigrations(db);
+      await checkForMigrations(db);
+    } catch (error) {
+      // Non-fatal: mirror DB failure should not block main database startup
+      logger.error('[v1]: Error setting up MySQL mirror database:', error);
+    }
   } else if (mirrorConfig == 'mirrorTest') {
     await checkForMigrations(sequelizeMirror);
   }
