fix: route SQLite pragma warnings to version logs

TheLastCicada · TheLastCicada · commit bc6b2472c505 · 2026-05-06T10:43:55.000-07:00
Pass the V1 and V2 loggers into the shared SQLite tuning helper so any
best-effort setup warning lands with the matching database logs.
diff --git a/src/database/index.js b/src/database/index.js
@@ -41,12 +41,12 @@ if (nodeEnv === 'test') {
 }
 
 export const sequelize = new Sequelize(config[dbConfigKey]);
-installSqlitePragmas(sequelize);
+installSqlitePragmas(sequelize, logger);
 
 const mirrorConfig =
   (process.env.NODE_ENV || 'local') === 'local' ? 'mirror' : 'mirrorTest';
 export const sequelizeMirror = new Sequelize(config[mirrorConfig]);
-installSqlitePragmas(sequelizeMirror);
+installSqlitePragmas(sequelizeMirror, logger);
 
 // Snapshot of whether V1 MIRROR_DB was fully configured at module-load time.
 // Captured alongside sequelizeMirror construction so mirrorDBEnabled() stays
diff --git a/src/database/sqlite-pragmas.js b/src/database/sqlite-pragmas.js
@@ -1,5 +1,3 @@
-import { logger } from '../config/logger.js';
-
 const SQLITE_PRAGMAS = [
   'PRAGMA journal_mode = WAL',
   'PRAGMA synchronous = NORMAL',
@@ -24,7 +22,7 @@ const applySqlitePragmas = async (connection) => {
   });
 };
 
-export const installSqlitePragmas = (sequelize) => {
+export const installSqlitePragmas = (sequelize, pragmaLogger = console) => {
   if (sequelize.getDialect() !== 'sqlite') {
     return;
   }
@@ -42,7 +40,7 @@ export const installSqlitePragmas = (sequelize) => {
         configuredConnections.add(connection);
       } catch (error) {
         const message = error instanceof Error ? error.message : String(error);
-        logger.warn(`Could not apply SQLite PRAGMAs: ${message}`);
+        pragmaLogger.warn(`Could not apply SQLite PRAGMAs: ${message}`);
       }
     }
 
diff --git a/src/database/v2/index.js b/src/database/v2/index.js
@@ -40,7 +40,7 @@ if (nodeEnv === 'test') {
 }
 
 export const sequelizeV2 = new Sequelize(config[dbConfigKey]);
-installSqlitePragmas(sequelizeV2);
+installSqlitePragmas(sequelizeV2, loggerV2);
 
 // Determine if MySQL mirror is configured by checking the actual config values
 // This allows MySQL mirror to work in any environment (local, test, production)
@@ -82,7 +82,7 @@ const isMysqlMirrorConfiguredForReconnectV2 = () => {
 };
 
 export const sequelizeV2Mirror = new Sequelize(config[mirrorConfig]);
-installSqlitePragmas(sequelizeV2Mirror);
+installSqlitePragmas(sequelizeV2Mirror, loggerV2);
 
 // Snapshot of "is the mirror Sequelize instance actually pointing at MySQL"
 // taken at module-load time, alongside sequelizeV2Mirror construction.
