fix(V2): batch cascade unit reference checks

TheLastCicada · TheLastCicada · commit bc31e658acc6 · 2026-05-21T10:55:39.000-07:00
diff --git a/src/controllers/v2/project-v2.controller.js b/src/controllers/v2/project-v2.controller.js
@@ -36,29 +36,11 @@ import { projectV2Schema } from '../../validations/v2/project-v2.validations.js'
 import { formatModelAssociationName } from '../../utils/model-utils.js';
 import { resolveOrgUid } from '../../utils/owner-utils.js';
 import { getProjectCascadeUnits, stageProjectChildDeletes } from '../../utils/v2-cascade-delete.js';
-import { checkReferences, buildReferenceConflictBody } from '../../utils/v2-reference-guards.js';
+import { checkReferences, buildReferenceConflictBody, checkUnitReferencesForIds } from '../../utils/v2-reference-guards.js';
 
 const checkProjectCascadeUnitReferences = async (projectId) => {
   const units = await getProjectCascadeUnits(projectId);
-  const referencesByTable = new Map();
-
-  for (const unit of units) {
-    const unitRefResult = await checkReferences('unit', unit.cadTrustUnitId);
-    for (const reference of unitRefResult.references) {
-      const existing = referencesByTable.get(reference.table);
-      if (existing) {
-        existing.count += reference.count;
-      } else {
-        referencesByTable.set(reference.table, { ...reference });
-      }
-    }
-  }
-
-  const references = [...referencesByTable.values()];
-  return {
-    hasReferences: references.length > 0,
-    references,
-  };
+  return checkUnitReferencesForIds(units.map((unit) => unit.cadTrustUnitId));
 };
 
 export const create = async (req, res) => {
diff --git a/src/utils/v2-reference-guards.js b/src/utils/v2-reference-guards.js
@@ -197,6 +197,35 @@ const countStagedReferences = async (table, snakeFkField, recordId, matchPredica
   return count;
 };
 
+const countStagedReferencesForIds = async (table, snakeFkField, recordIds) => {
+  const recordIdSet = new Set(recordIds);
+  const stagedRows = await StagingV2.findAll({
+    where: {
+      table,
+      action: { [Op.in]: ['INSERT', 'UPDATE'] },
+      committed: false,
+      failed_commit: false,
+    },
+    raw: true,
+  });
+
+  let count = 0;
+  for (const stagedRow of stagedRows) {
+    try {
+      const parsedData = JSON.parse(stagedRow.data);
+      const records = Array.isArray(parsedData) ? parsedData : [parsedData];
+      for (const record of records) {
+        if (recordIdSet.has(record?.[snakeFkField])) {
+          count += 1;
+        }
+      }
+    } catch {
+      continue;
+    }
+  }
+  return count;
+};
+
 const findPendingStagedDeleteIds = async (table, primaryKeyField) => {
   const stagedRows = await StagingV2.findAll({
     where: {
@@ -270,6 +299,42 @@ export const checkReferences = async (table, recordId) => {
   };
 };
 
+export const checkUnitReferencesForIds = async (unitIds) => {
+  const recordIds = unitIds.filter(Boolean);
+  if (recordIds.length === 0) {
+    return { hasReferences: false, references: [] };
+  }
+
+  const definitions = REFERENCE_MAP.unit;
+  const references = [];
+
+  for (const def of definitions) {
+    const { model, fkField, table: refTable, label } = def;
+    const primaryKeyAttr = model.primaryKeyAttribute;
+    const primaryKeyField = getV2PrimaryKeyField(refTable) || toSnakeCase(primaryKeyAttr);
+    const pendingDeleteIds = await findPendingStagedDeleteIds(refTable, primaryKeyField);
+    const mainRecords = await model.findAll({
+      where: { [fkField]: { [Op.in]: recordIds } },
+      raw: true,
+    });
+    const mainCount = mainRecords.filter((row) => {
+      const rowId = row?.[primaryKeyAttr] ?? row?.[primaryKeyField];
+      return !pendingDeleteIds.has(rowId);
+    }).length;
+
+    const stagedCount = await countStagedReferencesForIds(refTable, toSnakeCase(fkField), recordIds);
+    const totalCount = mainCount + stagedCount;
+    if (totalCount > 0) {
+      references.push({ table: refTable, count: totalCount, label });
+    }
+  }
+
+  return {
+    hasReferences: references.length > 0,
+    references,
+  };
+};
+
 /**
  * Build a 409 response body from a reference check result.
  *
diff --git a/tests/v2/integration/project-v2.spec.js b/tests/v2/integration/project-v2.spec.js
@@ -2247,6 +2247,12 @@ Test Registry,REQ-001,${testProgram.cadTrustProgramId}`;
           projectRegistryName: 'Test Registry',
           projectId: 'UPD-REQ-001',
           projectName: 'Full Project',
+          projectLink: 'https://example.com/update-required',
+          projectSector: ['Agriculture'],
+          projectType: ['Landfill gas'],
+          projectStatus: 'Listed',
+          projectStatusDate: '2024-01-01',
+          projectUnitMetric: 'tCO2e',
           orgUid: homeOrgId,
         }));
 
