refactor(V2): polish comments per review feedback

TheLastCicada · TheLastCicada · commit 76be7111f389 · 2026-04-24T11:48:26.000-07:00
- Drop "Reduced from" history sentence from COMMIT_POLL_INTERVAL_MS
  comment; intent and trade-off are sufficient, history lives in git log
- Add tradeoff comment on the merged cascade-delete it() explaining why
  Graph A + Graph B share one it() despite reduced failure isolation
diff --git a/tests/v2/live-api/cascade-delete.live.spec.js b/tests/v2/live-api/cascade-delete.live.spec.js
@@ -51,6 +51,11 @@ describe('Cascade Delete Live API Tests', function () {
     return parsed.some((p) => p?.[key] === value);
   });
 
+  // Graphs A and B are intentionally combined into one it() to share a single
+  // on-chain commit cycle.  Trade-off: a Graph A assertion failure will abort
+  // the test before Graph B executes.  Accepted because the two graphs share
+  // the same commit, and duplicating the commit cycle for isolation would cost
+  // ~2 min per CI run.
   it('should cascade delete project and sub-entity children through commit', async function () {
     // === Graph A: full project cascade (project + 11 children) ===
     const programAId = await postAndGetId('/v2/program', generateProgram(), 'cadTrustProgramId');
diff --git a/tests/v2/live-api/helpers/live-api-helpers.js b/tests/v2/live-api/helpers/live-api-helpers.js
@@ -10,11 +10,10 @@ import {
   createRecoveryStuckTracker,
 } from './wallet-diagnostics.js';
 
-// Reduced from 10 000 ms to cut idle wait time between blockchain commits.
 // Each iteration calls two HTTP endpoints (org-synced + wallet-diagnostics),
-// so the total request rate increase across all live jobs is ~6.7× vs the old
-// 10 s interval.  Both jobs (test-v2-live-api, test-v2-live-cascade-delete)
-// use this helper; the 30-minute suite timeout is not at risk.
+// so the per-loop request rate is ~6.7× the org-creation polling interval.
+// Both live jobs (test-v2-live-api, test-v2-live-cascade-delete) share this
+// helper; the 30-minute suite timeout is not at risk.
 const COMMIT_POLL_INTERVAL_MS = 3000;
 
 /**
