fix(V2): strengthen cascade-delete staging assertions

TheLastCicada · TheLastCicada · commit 741dec058a5c · 2026-04-24T11:47:25.000-07:00
- Add exact DELETE row count guards after each staging query
  (12 for Graph A, 21 for Graph A + Graph B combined) to catch mutations
  that stage spurious extra rows without changing the stagedChildDeletes
  counter
- Expand Graph B survivor list to include val1Id/val2Id/val3Id — the
  parent validations whose child verifications were deleted; these must
  NOT be cascade-deleted upward
diff --git a/tests/v2/live-api/cascade-delete.live.spec.js b/tests/v2/live-api/cascade-delete.live.spec.js
@@ -136,6 +136,10 @@ describe('Cascade Delete Live API Tests', function () {
       expect(hasStagedDelete(stagedRowsA, table, key, value), `missing staged delete ${table}:${value}`).to.equal(true);
     }
 
+    // Exact row count guards against spurious over-staging (12 = 11 children + project itself)
+    const deleteRowsA = stagedRowsA.filter((r) => r.action === 'DELETE');
+    expect(deleteRowsA.length, 'unexpected extra staged deletes in Graph A').to.equal(12);
+
     // --- Graph B deletes: unit3, issuance2, verification1 ---
     const unitDelResp = await request.delete(`/v2/unit/${unit3Id}`).expect(200);
     expect(unitDelResp.body.success).to.equal(true);
@@ -171,6 +175,10 @@ describe('Cascade Delete Live API Tests', function () {
       expect(hasStagedDelete(stagedRowsB, table, key, value), `missing staged delete ${table}:${value}`).to.equal(true);
     }
 
+    // Exact row count: 12 from Graph A + 9 from Graph B = 21 DELETE rows total
+    const deleteRowsB = stagedRowsB.filter((r) => r.action === 'DELETE');
+    expect(deleteRowsB.length, 'unexpected extra staged deletes after Graph B').to.equal(21);
+
     // --- Commit cycle 2: commit all deletes (both graphs) in one pass ---
     await commitStagedRecords(request, [], true);
     await waitForPendingCommits(request);
@@ -216,10 +224,15 @@ describe('Cascade Delete Live API Tests', function () {
     }
 
     // Verify non-deleted Graph B siblings are still present (guards against
-    // overly-aggressive cascades that silently delete sibling entities)
+    // overly-aggressive cascades that silently delete sibling entities).
+    // val1/val2/val3 are parent validations whose child verifications were
+    // deleted — they must NOT be cascade-deleted upward.
     const survivingGraphB = [
       ['/v2/project', projectBId],
       ['/v2/project-methodology', pm1Id],
+      ['/v2/validation', val1Id],
+      ['/v2/validation', val2Id],
+      ['/v2/validation', val3Id],
       ['/v2/verification', ver2Id],
       ['/v2/verification', ver3Id],
       ['/v2/issuance', iss3Id],
