refactor: drop redundant orglist length guard in resubscribe check

TheLastCicada · TheLastCicada · commit 58faac480d1c · 2026-06-01T11:40:01.000-07:00
The check ran inside a loop over the orglist, so the length guard was
always true. The empty-list safety guard lives in
unsubscribeOrgsNotInOrgList where it is actually needed.
diff --git a/src/tasks/sync-default-organizations-v2.js b/src/tasks/sync-default-organizations-v2.js
@@ -56,11 +56,7 @@ const task = new Task('sync-default-organizations-v2', async () => {
           pending.push(orgUid);
         } else {
           imported.push(orgUid);
-          if (
-            onlyCadtSubscriptions &&
-            defaultOrgList.length > 0 &&
-            !Boolean(organization.subscribed)
-          ) {
+          if (onlyCadtSubscriptions && !organization.subscribed) {
             resubscribePending.push(orgUid);
           }
         }
diff --git a/src/tasks/sync-default-organizations.js b/src/tasks/sync-default-organizations.js
@@ -56,11 +56,7 @@ const task = new Task('sync-default-organizations', async () => {
           pending.push(orgUid);
         } else {
           imported.push(orgUid);
-          if (
-            onlyCadtSubscriptions &&
-            defaultOrgRecords.length > 0 &&
-            !Boolean(organization.subscribed)
-          ) {
+          if (onlyCadtSubscriptions && !organization.subscribed) {
             resubscribePending.push(orgUid);
           }
         }

Original file line number	Diff line number	Diff line change
`@@ -56,11 +56,7 @@ const task = new Task('sync-default-organizations-v2', async () => {`
`56`	`56`	`pending.push(orgUid);`
`57`	`57`	`} else {`
`58`	`58`	`imported.push(orgUid);`
`59`		`- if (`
`60`		`- onlyCadtSubscriptions &&`
`61`		`- defaultOrgList.length > 0 &&`
`62`		`- !Boolean(organization.subscribed)`
`63`		`- ) {`
	`59`	`+ if (onlyCadtSubscriptions && !organization.subscribed) {`
`64`	`60`	`resubscribePending.push(orgUid);`
`65`	`61`	`}`
`66`	`62`	`}`