fix(V2): add committed filter and reuse toSnakeCase in reference guards

TheLastCicada · TheLastCicada · commit 3b0f92043dd0 · 2026-04-07T21:57:44.000-07:00
Address bugbot findings: add `committed: false` to the staging query
to prevent double-counting references after commit but before sync
cleanup, and replace the local toSnakeCase with the existing export
from v2-camel-to-snake.js.
diff --git a/src/utils/v2-reference-guards.js b/src/utils/v2-reference-guards.js
@@ -19,6 +19,7 @@ import {
   StagingV2,
 } from '../models/v2/index.js';
 import { Op } from 'sequelize';
+import { toSnakeCase } from './v2-camel-to-snake.js';
 
 const REFERENCE_MAP = {
   methodology: [
@@ -55,13 +56,12 @@ const REFERENCE_MAP = {
   ],
 };
 
-const toSnakeCase = (value) => value.replace(/[A-Z]/g, (char) => `_${char.toLowerCase()}`);
-
 const countStagedReferences = async (table, snakeFkField, recordId) => {
   const stagedRows = await StagingV2.findAll({
     where: {
       table,
       action: { [Op.in]: ['INSERT', 'UPDATE'] },
+      committed: false,
       failed_commit: false,
     },
     raw: true,
