Skip to content

Commit 31f8293

Browse files
committed
fix(V2): revert xlsx round-trip commit folding
Cross-process module-level variables (beforeProjects, beforeUnits) set in a separate mocha subprocess cannot be read by a subsequent subprocess invocation. Additionally, committing XLSX round-trip and PUT changes in the same cycle would cause Step 15a fidelity assertions to fail for any project/unit also modified by PUT tests. Restore the original single-pass XLSX invocation and the standalone Step 15 commit it() block. The 3-pass interleaved approach is dropped; Opts 1-3 (cascade-delete CI split, merged it() blocks, 3s poll interval) are retained.
1 parent a34cab7 commit 31f8293

2 files changed

Lines changed: 7 additions & 10 deletions

File tree

tests/v2/live-api/data-short.js

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -394,20 +394,12 @@ async function main() {
394394
console.log('');
395395

396396
const xlsxTestFiles = ['xlsx-import-export.live.spec.js'];
397+
await runMochaTests('Step 1[1-6]a?:', 'XLSX Import/Export', xlsxTestFiles);
397398

398-
// Pass 1: XLSX imports + verify + export (1 on-chain commit from Step 11)
399-
await runMochaTests('Step 11:|Step 11a:|Step 12a:|Step 13:|Step 14:', 'XLSX Import/Export (imports)', xlsxTestFiles);
400-
401-
// Pass 2: XLSX round-trip staging only (no separate commit — absorbed into PUT commit below)
402-
await runMochaTests('Step 15: Round-trip re-import \\(batch\\)', 'XLSX Round-trip Staging', xlsxTestFiles);
403-
404-
// Phase 4: PUT tests (stages on top of XLSX round-trip; one commit covers both)
399+
// Phase 4: PUT tests
405400
await runMochaTests('Step 7: PUT Request Tests', 'PUT Operations');
406401
await commitAndWait('PUT');
407402

408-
// Pass 3: XLSX round-trip verify + filter export (reads now-committed data)
409-
await runMochaTests('Step 15a:|Step 16:', 'XLSX Round-trip Verify + Filter Export', xlsxTestFiles);
410-
411403
// Phase 5: DELETE tests
412404
await runMochaTests('Step 9: DELETE Request Tests', 'DELETE Operations');
413405
await commitAndWait('DELETE');

tests/v2/live-api/xlsx-import-export.live.spec.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -515,6 +515,11 @@ describe('XLSX Import/Export Live API Tests', function () {
515515
expect(importResponse.body.success).to.be.true;
516516
});
517517

518+
it('should commit all round-trip staged records', async function () {
519+
await commitStagedRecords(request, [], true);
520+
await waitForPendingCommits(request);
521+
await waitForStagingEmpty(request);
522+
});
518523
});
519524

520525
describe('Step 15a: Verify round-trip fidelity', function () {

0 commit comments

Comments
 (0)