feat(API): report non-default task intervals in diagnostics

TheLastCicada · TheLastCicada · commit 2f74d8ee37b4 · 2026-06-05T13:21:00.000-07:00
Add cadt.nonDefaultTaskIntervals to /diagnostics, listing each
APP.TASKS interval that differs from defaultConfig with default and
actual values in seconds.
diff --git a/src/routes/diagnostics.js b/src/routes/diagnostics.js
@@ -14,6 +14,7 @@
 import _ from 'lodash';
 
 import { getConfig, getConfigV2 } from '../utils/config-loader.js';
+import { defaultConfig } from '../utils/defaultConfig.js';
 import { getChiaRoot } from '../utils/chia-root.js';
 import { getWalletHealthResponse } from './wallet-health.js';
 import { getSystemInfo } from '../utils/system-info.js';
@@ -340,6 +341,32 @@ const normalizeNodeId = (id) => {
   return s.startsWith('0x') ? s.slice(2) : s;
 };
 
+/** Task interval keys shipped in defaultConfig.APP.TASKS. */
+const TASK_INTERVAL_KEYS = Object.freeze([
+  'GOVERNANCE_SYNC_TASK_INTERVAL',
+  'ORGANIZATION_META_SYNC_TASK_INTERVAL',
+  'PICKLIST_SYNC_TASK_INTERVAL',
+  'MIRROR_CHECK_TASK_INTERVAL',
+  'VALIDATE_ORGANIZATION_TABLE_TASK_INTERVAL',
+  'COIN_MANAGEMENT_TASK_INTERVAL',
+]);
+
+/**
+ * Compare effective APP.TASKS intervals against defaultConfig. Returns only
+ * entries whose actual value differs from the shipped default, each with
+ * { key, default, actual } in seconds.
+ */
+const collectNonDefaultTaskIntervals = (actualTasks, defaultTasks = defaultConfig.APP.TASKS) => {
+  const nonDefault = [];
+  for (const key of TASK_INTERVAL_KEYS) {
+    const defaultValue = defaultTasks?.[key];
+    const actualValue = actualTasks?.[key];
+    if (actualValue === undefined || actualValue === defaultValue) continue;
+    nonDefault.push({ key, default: defaultValue, actual: actualValue });
+  }
+  return nonDefault;
+};
+
 /**
  * Cross-reference connected wallet peers against the trusted_peers map in
  * the chia config.yaml. Returns a small object suitable for embedding in
@@ -573,6 +600,7 @@ export const getDiagnosticsResponse = async () => {
       governanceBodyId: configV2.GOVERNANCE?.GOVERNANCE_BODY_ID || null,
       homeOrgId: homeOrgUid(v2HomeOrg),
     },
+    nonDefaultTaskIntervals: collectNonDefaultTaskIntervals(appConfig.TASKS),
   };
 
   // ---- Chia: network match ------------------------------------------------
@@ -881,6 +909,8 @@ export const __test = {
   buildTrustedPeerView,
   normalizeNodeId,
   collectOwnedStoreExpectations,
+  collectNonDefaultTaskIntervals,
   escalateLostOwnedStores,
   StatusAccumulator,
+  TASK_INTERVAL_KEYS,
 };
diff --git a/tests/v2/integration/diagnostics-helpers.spec.js b/tests/v2/integration/diagnostics-helpers.spec.js
@@ -578,3 +578,51 @@ describe('collectOwnedStoreExpectations', function () {
     expect(result.expectedOwnedStores.map((e) => e.label)).to.deep.equal(['v1 registry']);
   });
 });
+
+describe('diagnostics collectNonDefaultTaskIntervals', function () {
+  const { collectNonDefaultTaskIntervals } = diagnosticsTest;
+
+  const defaultTasks = {
+    GOVERNANCE_SYNC_TASK_INTERVAL: 120,
+    ORGANIZATION_META_SYNC_TASK_INTERVAL: 120,
+    PICKLIST_SYNC_TASK_INTERVAL: 120,
+    MIRROR_CHECK_TASK_INTERVAL: 900,
+    VALIDATE_ORGANIZATION_TABLE_TASK_INTERVAL: 1800,
+    COIN_MANAGEMENT_TASK_INTERVAL: 21600,
+  };
+
+  it('returns an empty array when all intervals match defaults', function () {
+    expect(collectNonDefaultTaskIntervals(defaultTasks, defaultTasks)).to.deep.equal([]);
+  });
+
+  it('reports only intervals that differ from defaults', function () {
+    const actual = {
+      ...defaultTasks,
+      GOVERNANCE_SYNC_TASK_INTERVAL: 30,
+      MIRROR_CHECK_TASK_INTERVAL: 900,
+    };
+    expect(collectNonDefaultTaskIntervals(actual, defaultTasks)).to.deep.equal([
+      { key: 'GOVERNANCE_SYNC_TASK_INTERVAL', default: 120, actual: 30 },
+    ]);
+  });
+
+  it('reports multiple non-default intervals', function () {
+    const actual = {
+      ...defaultTasks,
+      PICKLIST_SYNC_TASK_INTERVAL: 60,
+      COIN_MANAGEMENT_TASK_INTERVAL: 3600,
+    };
+    expect(collectNonDefaultTaskIntervals(actual, defaultTasks)).to.deep.equal([
+      { key: 'PICKLIST_SYNC_TASK_INTERVAL', default: 120, actual: 60 },
+      { key: 'COIN_MANAGEMENT_TASK_INTERVAL', default: 21600, actual: 3600 },
+    ]);
+  });
+
+  it('ignores unknown task keys and missing actual values', function () {
+    const actual = {
+      GOVERNANCE_SYNC_TASK_INTERVAL: 120,
+      DEFAULT_ORGANIZATIONS_SYNC_TASK_INTERVAL: 30,
+    };
+    expect(collectNonDefaultTaskIntervals(actual, defaultTasks)).to.deep.equal([]);
+  });
+});
diff --git a/tests/v2/integration/diagnostics.spec.js b/tests/v2/integration/diagnostics.spec.js
@@ -34,6 +34,30 @@ describe('/diagnostics endpoint', function () {
       expect(cadt).to.have.property('v2').that.is.an('object');
       expect(cadt.v1).to.have.property('governanceBodyId');
       expect(cadt.v2).to.have.property('governanceBodyId');
+      expect(cadt).to.have.property('nonDefaultTaskIntervals').that.is.an('array');
+    });
+
+    it('reports non-default task intervals with default and actual values', async function () {
+      await withConfigOverride(async () => {
+        const response = await supertest(app).get('/diagnostics').expect(200);
+        expect(response.body.cadt.nonDefaultTaskIntervals).to.deep.include({
+          key: 'GOVERNANCE_SYNC_TASK_INTERVAL',
+          default: 120,
+          actual: 30,
+        });
+        expect(response.body.cadt.nonDefaultTaskIntervals).to.deep.include({
+          key: 'MIRROR_CHECK_TASK_INTERVAL',
+          default: 900,
+          actual: 86460,
+        });
+      }, {
+        APP: {
+          TASKS: {
+            GOVERNANCE_SYNC_TASK_INTERVAL: 30,
+            MIRROR_CHECK_TASK_INTERVAL: 86460,
+          },
+        },
+      });
     });
 
     it('reports CPU, memory, and disk in the system section', async function () {
