fix(API): return 500 instead of 200 on diagnostics endpoint failure

TheLastCicada · TheLastCicada · commit 28b0a1eaaa44 · 2026-05-15T11:37:32.000-07:00
getDiagnosticsResponse handles all subsystem failures internally via
settle(), so an exception reaching the outer catch is a genuine bug
that should be surfaced to monitoring tools as a 500.
diff --git a/src/middleware.js b/src/middleware.js
@@ -542,7 +542,7 @@ app.get('/diagnostics', async (req, res) => {
     return res.status(200).json(result);
   } catch (error) {
     logger.error(`[diagnostics]: unexpected error building response: ${error.message}`);
-    return res.status(200).json({
+    return res.status(500).json({
       timestamp: new Date().toISOString(),
       error: `Failed to build diagnostics response: ${error.message}`,
     });
