Turn on the BUILD_LIBRARY_FOR_DISTRIBUTION flag#4912
Merged
pmairoldi merged 1 commit intoChartsOrg:release/5.0.0from Mar 21, 2023
matopeto:feature/build_library_for_distribution
Merged
Turn on the BUILD_LIBRARY_FOR_DISTRIBUTION flag#4912pmairoldi merged 1 commit intoChartsOrg:release/5.0.0from matopeto:feature/build_library_for_distribution
pmairoldi merged 1 commit intoChartsOrg:release/5.0.0from
matopeto:feature/build_library_for_distribution
Conversation
kwlblaack
approved these changes
Sep 15, 2022
Closed
1 task
|
Do we have an ETA to make a release with this change? |
krishnkishore
approved these changes
Nov 30, 2022
1 task
This was referenced Sep 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link 🔗
#4871
Goals ⚽
Make the library "module stable" so compiled xcframework can be used in newer version of Xcode/swift without recompile
Implementation Details 🚧
Turned on the build setting
BUILD_LIBRARY_FOR_DISTRIBUTIONAlso added
@_implementationOnlyto silence the warning described in #4871Testing Details 🔍
I tested compiled xcframework with Xcode 13.4 and worked in Xcode 14