fixed no used warning#4841
Merged
pmairoldi merged 1 commit intoChartsOrg:release/5.0.0from Mar 21, 2023
Merged
Conversation
pmairoldi
requested changes
Aug 28, 2022
Collaborator
pmairoldi
left a comment
There was a problem hiding this comment.
I think we should just change the function to return void instead. I can't think of a case where we need to know if the result had been added successfully.
This was referenced Sep 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link 🔗
Goals ⚽
there will be no warning in demo project
Implementation Details 🚧
As I noticed in the demo project, it was giving a warning that the addEntryOrdered(_ e: ChartDataEntry) function is not used. That's why I made the development
Testing Details 🔍