BuildFix: fix build as part of SPM#4550
Closed
ArthurValiev wants to merge 1 commit intoChartsOrg:masterfrom
ArthurValiev:bugfix/spm_build_fix
Closed
BuildFix: fix build as part of SPM#4550ArthurValiev wants to merge 1 commit intoChartsOrg:masterfrom ArthurValiev:bugfix/spm_build_fix
ArthurValiev wants to merge 1 commit intoChartsOrg:masterfrom
ArthurValiev:bugfix/spm_build_fix
Conversation
Author
|
Found one open similar PR #4539 which fixes missing imports but that one does not includes fixes for macOS. Build fails with macOS as target with missing AppKit. |
1 task
Merged
Collaborator
|
Resolved by #4553 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link 🔗
#4016
Goals ⚽
Changes
Testing Details 🔍
Performed some very basic testing by replacing the remote SPM dependency with a local one and adding it as a dependency to 3 projects that target macOS, tvOS and iOS. Build now successfully passes.
Tested basic graph cases in my own iOS project. Works fine in my use case.