Add lineJoinType and miterLimit parameters to LineChartDataSet (fixes #2180 )#3797
Closed
anton-filimonov wants to merge 1 commit intoChartsOrg:masterfrom
anton-filimonov:bugfix_lineJoinParametersForLineChart
Closed
Add lineJoinType and miterLimit parameters to LineChartDataSet (fixes #2180 )#3797anton-filimonov wants to merge 1 commit intoChartsOrg:masterfrom anton-filimonov:bugfix_lineJoinParametersForLineChart
anton-filimonov wants to merge 1 commit intoChartsOrg:masterfrom
anton-filimonov:bugfix_lineJoinParametersForLineChart
Conversation
…et users fix issue with sharp edges the way they want
Codecov Report
@@ Coverage Diff @@
## master #3797 +/- ##
==========================================
+ Coverage 32.67% 32.69% +0.01%
==========================================
Files 114 114
Lines 10754 10757 +3
==========================================
+ Hits 3514 3517 +3
Misses 7240 7240
Continue to review full report at Codecov.
|
Member
|
eh, is this PR exclusive to #3764? meaning we should only merge one of the two? |
Author
|
@liuxuan30 yes. Another one breaks line joins for single color line (for multicolored line it was broken long ago), so we have to choose only one of them |
Member
|
OK. Let's discuss in #3764 then to find a proper one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
let users fix sharp edges the way they want, keeping default behaviour same as current.
Issue Link 🔗
#2180
Implementation Details 🚧
There is another PR that is made to solve same issue but it changes the default behaviour and actually also breaks line joins when
lineCapTypeis not.round. This PR is another way to solve that problem, but it also not ideal - multicolored line will not use introducedlineJoinTypeproperty because of tricky way to draw that line (actually that tricky way leads to bad line whenlineCapTypeis not.round)