Resubmit of #2730#3002
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3002 +/- ##
==========================================
+ Coverage 20% 20.64% +0.64%
==========================================
Files 113 114 +1
Lines 15529 15431 -98
Branches 249 256 +7
==========================================
+ Hits 3106 3186 +80
+ Misses 12387 12208 -179
- Partials 36 37 +1
Continue to review full report at Codecov.
|
|
With the revert to isEqual seems like methods are just moved around. Is there any meaningful change anymore? |
|
|
@petester42 Any further feedback on this one or can it be merged? |
|
@jjatie we still need a review process for what coming into master. |
|
Agreed. This was a PR that has had feedback back and forth since August. On the PR this one replaced, we agreed this would be merged in after the Swift 4 migration. I made the adjustments requested from the review, and this has just been sitting here since. This PR removes a few mistaken |
| @@ -0,0 +1,45 @@ | |||
| // | |||
| // EquatableTests.swift | |||
There was a problem hiding this comment.
I made the same template as yours for combined chart test. Shall we include the license info just like source code template, or test file is fine with default Xcode template?
The old test file does not have a template as well
There was a problem hiding this comment.
I guess we should be putting in the license info to be consistent. Do we keep it the same, but whose name do we use?
There was a problem hiding this comment.
I would just use the same template as source code. I don't know the rule of names.
Personally I just use Copyright 2015 Daniel Cohen Gindi & Philipp Jahoda, and I don't need to specify who created the file.
I think this is a good question, as I saw some files with yours template:
//
// DemoBaseViewController.swift
// ChartsDemo-iOS
//
// Created by Jacob Christie on 2017-07-03.
// Copyright © 2017 jc. All rights reserved.
//
I guess we need an unified one. @petester42 @danielgindi @PhilJay insights?
There was a problem hiding this comment.
Yea, I just use the Xcode default.
|
Just one thing: Please conform to the overall style of the library. In any codebase that I participate - I use the style of that codebase, braces up or down, spaces or no spaces, var naming etc. |
|
@danielgindi how about the file template about license and names? |
Resubmit of #2730