chore: update minimal_config to latest spec#8232
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @barnabasbusa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the minimal.ts configuration file to align with the latest specification for Ethereum's consensus parameters. The changes primarily involve significantly increasing the values for MAX_BLOB_COMMITMENTS_PER_BLOCK and KZG_COMMITMENT_INCLUSION_PROOF_DEPTH. This ensures the configuration reflects current protocol requirements, likely related to data availability sampling and blob transactions.
Highlights
- Configuration Update: Updated MAX_BLOB_COMMITMENTS_PER_BLOCK from 32 to 4096.
- Configuration Update: Updated KZG_COMMITMENT_INCLUSION_PROOF_DEPTH from 10 to 17.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the minimal preset configuration to align with the latest consensus specs. While the change to MAX_BLOB_COMMITMENTS_PER_BLOCK is correct, there's a critical issue with the updated value for KZG_COMMITMENT_INCLUSION_PROOF_DEPTH. It appears to be based on a version of the spec that contained a typo. The value should be 12, not 17, to correctly reflect floorlog2(MAX_BLOB_COMMITMENTS_PER_BLOCK). I've left a specific comment with a suggestion to fix this.
nflaig
left a comment
There was a problem hiding this comment.
@barnabasbusa I am not very optimistic this is gonna pass our sim tests as the minimal preset baked into Lighthouse still uses old values
|
|
||
| // ssz.deneb.BeaconBlockBody.getPathInfo(['blobKzgCommitments',0]).gindex | ||
| export const KZG_COMMITMENT_GINDEX0 = ACTIVE_PRESET === PresetName.minimal ? 1728 : 221184; | ||
| export const KZG_COMMITMENT_GINDEX0 = 221184; |
There was a problem hiding this comment.
this is the same now for minimal and mainnet
|
also need to wait for spec release to pass tests |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #8232 +/- ##
=========================================
Coverage 54.11% 54.12%
=========================================
Files 849 849
Lines 64043 64043
Branches 4856 4855 -1
=========================================
+ Hits 34657 34662 +5
+ Misses 29309 29304 -5
Partials 77 77 🚀 New features to boost your workflow:
|
|
🎉 This PR is included in v1.34.0 🎉 |
Motivation
Description
Update minimal preset to latest spec
Closes #8226