feat: modify fork digest to distinguish BPO forks#8022
Merged
Conversation
8eeab45 to
8d70582
Compare
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #8022 +/- ##
============================================
+ Coverage 55.68% 55.78% +0.09%
============================================
Files 835 834 -1
Lines 59476 59535 +59
Branches 4585 4599 +14
============================================
+ Hits 33119 33211 +92
+ Misses 26290 26256 -34
- Partials 67 68 +1 🚀 New features to boost your workflow:
|
…ters" This reverts commit 0262b31.
ensi321
reviewed
Jul 3, 2025
Co-authored-by: NC <17676176+ensi321@users.noreply.github.com>
ensi321
approved these changes
Jul 8, 2025
ensi321
left a comment
Contributor
There was a problem hiding this comment.
Thank you for making these changes 🙏
This part of Lodestar codebase is very confusing and it makes it difficult to implement this change correctly.
This was referenced Jul 14, 2025
Member
|
🎉 This PR is included in v1.32.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
ForkBoundary) which include both normal hard-forks (phase0, altair, etc.) and Blob Parameter Only (BPO) forks and are used to un-/subscribe to gossip topics and compute the fork digest primarily for domain separation on the p2p layerBlobParameters) when computing fork digest (computeForkDigest) post-fuluENRForkID) to consider fork boundaries (next fork digest (nfd) will be updated in feat: add next fork digest (nfd) entry to ENR #8023)