fix: only announce columns if fulu is scheduled in config#7964
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## peerDAS #7964 +/- ##
===========================================
- Coverage 54.37% 54.34% -0.04%
===========================================
Files 840 842 +2
Lines 61989 62118 +129
Branches 4654 4667 +13
===========================================
+ Hits 33707 33757 +50
- Misses 28214 28288 +74
- Partials 68 73 +5 🚀 New features to boost your workflow:
|
Member
|
🎉 This PR is included in v1.34.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Follow-up PR to #7943.
As per spec
we should only announce these if fulu is scheduled in config
Description
Only announce columns if fulu is scheduled in config