fix: support handshake-only with no muxers#519
Merged
achingbrain merged 1 commit intomasterfrom Apr 23, 2025
Merged
Conversation
Allows transports such as WebRTC-Direct to skip the early muxer negotiation. This handles an edge case where you have a libp2p node configured with no dedicated muxer(s), instead transport(s) that incorporate their own muxers but that use Noise to exchange PeerIDs. Splits the existing muxer negotiation test out into it's own file and adds more tests to handle the various configurations.
6e14ab4 to
05ee3bd
Compare
3 tasks
wemeetagain
pushed a commit
that referenced
this pull request
Apr 23, 2025
## [16.1.3](v16.1.2...v16.1.3) (2025-04-23) ### Bug Fixes * support handshake-only with no muxers ([#519](#519)) ([fd0e4f2](fd0e4f2))
Member
|
🎉 This PR is included in version 16.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows transports such as WebRTC-Direct to skip the early muxer negotiation.
This handles an edge case where you have a libp2p node configured with no dedicated muxer(s), instead transport(s) that incorporate their own muxers but that use Noise to exchange PeerIDs.
Splits the existing muxer negotiation test out into it's own file and adds more tests to handle the various configurations.