Add NewSecretKeyFromEd25519Bytes#59
Conversation
https://github.com/w3f/schnorrkel/blob/ab3e3d609cd8b9eefbe0333066f698c40fd09582/src/keys.rs#L495-L533 This is useful for working with the exported polkadot.js account JSON file.
|
|
| } | ||
| } | ||
|
|
||
| func NewSecretKeyFromEd25519Bytes(b [SecretKeySize + 32]byte) *SecretKey { |
There was a problem hiding this comment.
| func NewSecretKeyFromEd25519Bytes(b [SecretKeySize + 32]byte) *SecretKey { | |
| func NewSecretKeyFromEd25519Bytes(b [SecretKeySize + NonceSize]byte) *SecretKey { |
add a const NonceSize = 32 perhaps?
There was a problem hiding this comment.
If you look at the file, you'll see the number 32 all over the place. I don't want to refactor the whole file in this pull request. In my view the refactoring (which I agree should happen) should probably bring the constants closer to the rust implementation.
keys.go
Outdated
| copy(sk.key[:], b[:32]) | ||
| t := divideScalarByCofactor(sk.key[:]) | ||
|
|
||
| copy(sk.key[:], t) |
There was a problem hiding this comment.
| copy(sk.key[:], b[:32]) | |
| t := divideScalarByCofactor(sk.key[:]) | |
| copy(sk.key[:], t) | |
| copy(sk.key[:], divideScalarByCofactor(b[:32])) |
There was a problem hiding this comment.
This suggested change is not correct, because divideScalarByCofactor actually changes the slice in argument. But I'll commit the following, that has one copy less. Thanks.
diff --git a/keys.go b/keys.go
index 4ebfe1d..da0cf5b 100644
--- a/keys.go
+++ b/keys.go
@@ -118,9 +118,8 @@ func NewSecretKeyFromEd25519Bytes(b [SecretKeySize + 32]byte) *SecretKey {
}
copy(sk.key[:], b[:32])
- t := divideScalarByCofactor(sk.key[:])
+ divideScalarByCofactor(sk.key[:])
- copy(sk.key[:], t)
copy(sk.nonce[:], b[32:])
return sk
|
@oldgreen Thanks for this! All looks good to me, I believe you just still need to sign the contributor agreement |
https://github.com/w3f/schnorrkel/blob/ab3e3d609cd8b9eefbe0333066f698c40fd09582/src/keys.rs#L495-L533
This is useful for working with the exported polkadot.js account JSON file.