Func for generating mini secret for mnemonic#53
Merged
noot merged 3 commits intoChainSafe:masterfrom Apr 12, 2022
Merged
Conversation
|
|
noot
reviewed
Mar 17, 2022
bip39.go
Outdated
| // Designed for compatibility with the Rust substrate-bip39 library | ||
|
|
||
| // GenerateMiniSecretKeyMnemonic returns mnemonic for func MiniSecretKeyFromMnemonic | ||
| func GenerateMiniSecretKeyMnemonic() (string, error) { |
Contributor
There was a problem hiding this comment.
can you rename this to GenerateMnemonic?
noot
reviewed
Mar 17, 2022
bip39.go
Outdated
|
|
||
| // GenerateMiniSecretKeyMnemonic returns mnemonic for func MiniSecretKeyFromMnemonic | ||
| func GenerateMiniSecretKeyMnemonic() (string, error) { | ||
| entropy, err := bip39.NewEntropy(256) |
Contributor
There was a problem hiding this comment.
can you change 256 to a constant? eg const entropySize = 256 at the top of the function? also any particular reason for 256?
noot
reviewed
Mar 17, 2022
Contributor
noot
left a comment
There was a problem hiding this comment.
thanks for the PR! just a few comments, but looks good
rn generate mnemonic func name
noot
approved these changes
Apr 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.