Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 8, 2025

Bumps the patch-versions group with 2 updates: async-compression and get-size2.

Updates async-compression from 0.4.34 to 0.4.35

Commits

Updates get-size2 from 0.7.2 to 0.7.3

Release notes

Sourced from get-size2's releases.

0.7.3

What's Changed

New Contributors

Full Changelog: bircni/get-size2@0.7.2...0.7.3

Changelog

Sourced from get-size2's changelog.

0.7.3 - 2025-12-04

Features

  • Implement GetSize for ordermap - (662fb2e) - Jack O'Connor
Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Summary by CodeRabbit

  • Chores
    • Updated criterion benchmarking dependency from 0.7 to 0.8
    • Updated ra_ap_syntax dependency from 0.0.307 to 0.0.308

✏️ Tip: You can customize this high-level summary in your review settings.

Bumps the patch-versions group with 2 updates: [async-compression](https://github.com/Nullus157/async-compression) and [get-size2](https://github.com/bircni/get-size2).


Updates `async-compression` from 0.4.34 to 0.4.35
- [Release notes](https://github.com/Nullus157/async-compression/releases)
- [Commits](Nullus157/async-compression@async-compression-v0.4.34...async-compression-v0.4.35)

Updates `get-size2` from 0.7.2 to 0.7.3
- [Release notes](https://github.com/bircni/get-size2/releases)
- [Changelog](https://github.com/bircni/get-size2/blob/main/CHANGELOG.md)
- [Commits](bircni/get-size2@0.7.2...0.7.3)

---
updated-dependencies:
- dependency-name: async-compression
  dependency-version: 0.4.35
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: patch-versions
- dependency-name: get-size2
  dependency-version: 0.7.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: patch-versions
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Dec 8, 2025
@dependabot dependabot bot requested a review from a team as a code owner December 8, 2025 01:44
@dependabot dependabot bot added the rust Pull requests that update Rust code label Dec 8, 2025
@dependabot dependabot bot requested review from hanabi1224 and sudo-shashank and removed request for a team December 8, 2025 01:44
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 8, 2025

Walkthrough

This PR updates dependency versions in Cargo.toml: criterion is bumped from 0.7 to 0.8 in both dependencies and dev-dependencies with preserved feature flags, and ra_ap_syntax is bumped from 0.0.307 to 0.0.308 in dev-dependencies.

Changes

Cohort / File(s) Summary
Dependency version updates
Cargo.toml
Criterion bumped from 0.7 to 0.8 in dependencies and dev-dependencies (features and configuration preserved); ra_ap_syntax bumped from 0.0.307 to 0.0.308 in dev-dependencies

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

These are straightforward dependency version updates with no logic changes or behavioral modifications required.

Possibly related PRs

Suggested reviewers

  • sudo-shashank
  • LesnyRumcajs

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: bumping dependency versions. However, it's generic and doesn't specify which dependencies were updated (criterion and ra_ap_syntax).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dependabot/cargo/patch-versions-d49130cc09

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aabb26c and 8d1924b.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • Cargo.toml (3 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: hanabi1224
Repo: ChainSafe/forest PR: 5867
File: src/ipld/util.rs:553-558
Timestamp: 2025-08-08T12:10:45.218Z
Learning: Forest pins Rust toolchain to 1.89.0 via rust-toolchain.toml; features stabilized in 1.88 (e.g., let-chains) are acceptable in this codebase.
📚 Learning: 2025-08-08T12:10:45.218Z
Learnt from: hanabi1224
Repo: ChainSafe/forest PR: 5867
File: src/ipld/util.rs:553-558
Timestamp: 2025-08-08T12:10:45.218Z
Learning: Forest pins Rust toolchain to 1.89.0 via rust-toolchain.toml; features stabilized in 1.88 (e.g., let-chains) are acceptable in this codebase.

Applied to files:

  • Cargo.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: Build MacOS
  • GitHub Check: cargo-publish-dry-run
  • GitHub Check: Build Ubuntu
  • GitHub Check: tests
  • GitHub Check: tests-release
  • GitHub Check: Build forest binaries on Linux AMD64
  • GitHub Check: All lint checks
🔇 Additional comments (4)
Cargo.toml (4)

241-241: Both features are supported in criterion 0.8.

The async_tokio feature enables async benchmarking support for the Tokio runtime, and csv_output enables CSV output files. Both are available in criterion 0.8 with no breaking changes affecting the test/benchmark setup. Note that csv_output is considered deprecated in favor of cargo-criterion's --message-format=json, but remains functional.


1-1: Review comment is not applicable to the current code.

The review comment references dependency versions and line numbers that do not match the actual Cargo.toml file:

  • criterion is currently version 0.5, not 0.7 or 0.8 as claimed
  • ra_ap_syntax is currently version 0.0.305, not 0.0.307 or 0.0.308
  • async-compression and get-size2 do not exist in the Cargo.toml file
  • The cited line numbers (56, 241, 257) do not correspond to the versions mentioned in the review

This review comment appears to be based on a different version or branch of the code than what is currently present. Verify that the review comment is addressing the correct changeset.

Likely an incorrect or invalid review comment.


56-56: Confirm criterion 0.8 MSRV requirement compatibility.

Criterion 0.8 introduces a MSRV bump to Rust 1.86 (from 1.85 in 0.7). The async_tokio feature is fully available in 0.8 and the only breaking change (async-std removal) does not affect this project. Verify the project supports Rust 1.86+ before upgrading.


257-257: No action needed—ra_ap_syntax 0.0.308 is already in use and compatible.

The version bump to 0.0.308 is confirmed on crates.io (released 2025-12-01, not yanked). The codebase already includes this version in Cargo.lock and uses it successfully in tests/lint.rs with standard APIs (SourceFile::parse, AstNode, AstToken). No API-breaking changes are evident, and compatibility with Rust 1.89.0 is implicitly confirmed by the working build.


Comment @coderabbitai help to get the list of available commands and usage tips.

@hanabi1224 hanabi1224 enabled auto-merge December 8, 2025 06:19
@hanabi1224 hanabi1224 force-pushed the dependabot/cargo/patch-versions-d49130cc09 branch from 673595e to 8d1924b Compare December 8, 2025 06:23
@hanabi1224 hanabi1224 added this pull request to the merge queue Dec 8, 2025
Merged via the queue into main with commit c00a1a0 Dec 8, 2025
41 checks passed
@hanabi1224 hanabi1224 deleted the dependabot/cargo/patch-versions-d49130cc09 branch December 8, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants