Skip to content

Bump fvm version #6248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LesnyRumcajs merged 3 commits into from
Nov 15, 2025
Merged

Bump fvm version #6248

LesnyRumcajs merged 3 commits into from
Nov 15, 2025

Conversation

@LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Nov 15, 2025 •
edited by coderabbitai bot
Loading

Summary of changes

Changes introduced in this pull request:

  • update FVMs (and other deps)
  • removed advisory suppression for wasmtime (the updated FVMs now use wasmtime 36)

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Summary by CodeRabbit

  • Chores
    • Updated security advisory configuration to enforce stricter validation of project dependencies by removing exceptions from the ignore list.

@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner November 15, 2025 20:09
@LesnyRumcajs LesnyRumcajs requested review from hanabi1224 and removed request for a team November 15, 2025 20:09
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 15, 2025 •
edited
Loading

Walkthrough

The PR removes two Rust security advisory entries (RUSTSEC-2025-0046 and RUSTSEC-2025-0118) from the ignore list in the deny.toml advisory filtering configuration, allowing these advisories to be flagged by the dependency auditing tool.

Changes

Cohort / File(s) Summary
Dependency advisory configuration
deny.toml		 Removed entries for RUSTSEC-2025-0046 and RUSTSEC-2025-0118 from the [advisories] ignore list

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

dependencies

Suggested reviewers

  • hanabi1224
  • sudo-shashank
  • elmattic

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Bump fvm version' is vague and generic. While it references FVM, the actual changes involve removing advisory suppressions from deny.toml (RUSTSEC-2025-0046 and RUSTSEC-2025-0118), not just bumping FVM versions. Clarify the title to accurately reflect the main change. Consider: 'Remove wasmtime advisory suppressions from deny.toml' or 'Update FVM and remove advisory suppressions for wasmtime 36'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bump-fvm-version
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e8f322b and 27e2e24.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • deny.toml (0 hunks)
💤 Files with no reviewable changes (1)
  • deny.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: cargo-publish-dry-run
  • GitHub Check: Build Ubuntu
  • GitHub Check: Build MacOS
  • GitHub Check: tests
  • GitHub Check: tests-release
  • GitHub Check: All lint checks
  • GitHub Check: Build forest binaries on Linux AMD64

Comment @coderabbitai help to get the list of available commands and usage tips.

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Nov 15, 2025
Merged via the queue into main with commit 7e20eae Nov 15, 2025
41 checks passed
@LesnyRumcajs LesnyRumcajs deleted the bump-fvm-version branch November 15, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sudo-shashank sudo-shashank sudo-shashank approved these changes

@hanabi1224 hanabi1224 Awaiting requested review from hanabi1224 hanabi1224 is a code owner automatically assigned from ChainSafe/forest

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LesnyRumcajs @sudo-shashank