Skip to content

Conversation

@hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Nov 11, 2025

Summary of changes

Changes introduced in this pull request:

  • prepare Forest release v0.30.4 "DeLorean"

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Summary by CodeRabbit

Forest v0.30.4 "DeLorean"

  • Bug Fixes
    • Resolved a chain synchronization issue triggered by time-traveling blocks, which caused improper block validation and network inconsistencies. This update restores stable blockchain operations and improved sync reliability across the network.

@hanabi1224 hanabi1224 added RPC requires calibnet RPC checks to run on CI Release PR which marks a new Release labels Nov 11, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 11, 2025

Walkthrough

This pull request performs a version bump for Forest to v0.30.4, updating the package version in Cargo.toml and documenting a chain synchronization fix in the CHANGELOG related to time-traveling blocks.

Changes

Cohort / File(s) Summary
Version bump
Cargo.toml
Updated package version from 0.30.3 to 0.30.4
Release documentation
CHANGELOG.md
Added new release section for Forest v0.30.4 "DeLorean" with fix description for chain sync issue caused by time-traveling blocks, referencing PR #6241

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • These are straightforward version and changelog updates with no logic or functional changes to review

Suggested reviewers

  • akaladarshi
  • LesnyRumcajs
  • sudo-shashank

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: preparing a release version v0.30.4, which aligns with both the file changes (version bump in Cargo.toml) and the stated PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hm/v0.30.4

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 21cc6c6 and df96f5a.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • Cargo.toml (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: hanabi1224
Repo: ChainSafe/forest PR: 5867
File: src/ipld/util.rs:553-558
Timestamp: 2025-08-08T12:10:45.218Z
Learning: Forest project targets Rust stable >=1.89; features stabilized in 1.88 like let-chains are acceptable in this codebase.
Learnt from: elmattic
Repo: ChainSafe/forest PR: 6128
File: src/ipld/util.rs:23-30
Timestamp: 2025-10-17T09:36:15.757Z
Learning: Always run `cargo check` or `cargo build` to verify actual compilation errors in the Forest codebase before flagging them as issues. Do not rely solely on documentation or assumptions about trait implementations.
Learnt from: elmattic
Repo: ChainSafe/forest PR: 6128
File: src/ipld/util.rs:23-30
Timestamp: 2025-10-17T09:36:15.757Z
Learning: Always run `cargo check` or `cargo build` to verify actual compilation errors in the Forest codebase before flagging them as issues. Do not rely solely on documentation or assumptions about trait implementations.
Learnt from: hanabi1224
Repo: ChainSafe/forest PR: 5930
File: build.rs:64-77
Timestamp: 2025-08-13T09:43:20.301Z
Learning: hanabi1224 prefers hard compile-time errors in build scripts rather than runtime safeguards or collision detection, believing it's better to fail fast and fix root causes of issues like malformed snapshot names.
Learnt from: hanabi1224
Repo: ChainSafe/forest PR: 6057
File: src/cli/subcommands/f3_cmd.rs:0-0
Timestamp: 2025-09-09T10:37:17.947Z
Learning: hanabi1224 prefers having default timeouts (like 10m for --no-progress-timeout) to prevent commands from hanging indefinitely, even when the timeout flag isn't explicitly provided by users. This fail-fast approach is preferred over requiring explicit flag usage.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: tests
  • GitHub Check: tests-release
  • GitHub Check: Build forest binaries on Linux AMD64
  • GitHub Check: cargo-publish-dry-run
  • GitHub Check: Build MacOS
  • GitHub Check: Build Ubuntu
  • GitHub Check: All lint checks
🔇 Additional comments (2)
Cargo.toml (1)

3-3: Version bump to 0.30.4 looks good.

The patch-level version increment is correct and aligns with the PR objectives for the Forest v0.30.4 "DeLorean" release.

CHANGELOG.md (1)

38-44: CHANGELOG entry for v0.30.4 "DeLorean" is well-structured.

The new release section follows the template format, is positioned correctly above previous releases, and the description clearly communicates the fix. Version numbering is consistent with Cargo.toml.


Comment @coderabbitai help to get the list of available commands and usage tips.

@hanabi1224 hanabi1224 marked this pull request as ready for review November 11, 2025 08:37
@hanabi1224 hanabi1224 requested a review from a team as a code owner November 11, 2025 08:37
@hanabi1224 hanabi1224 requested review from LesnyRumcajs and sudo-shashank and removed request for a team November 11, 2025 08:37
@hanabi1224 hanabi1224 added this pull request to the merge queue Nov 11, 2025
@hanabi1224 hanabi1224 removed this pull request from the merge queue due to a manual request Nov 11, 2025
@hanabi1224 hanabi1224 added this pull request to the merge queue Nov 11, 2025
Merged via the queue into main with commit a06a1f0 Nov 11, 2025
80 of 106 checks passed
@hanabi1224 hanabi1224 deleted the hm/v0.30.4 branch November 11, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Release PR which marks a new Release RPC requires calibnet RPC checks to run on CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants