Skip to content

Conversation

@akaladarshi
Copy link
Collaborator

@akaladarshi akaladarshi commented Nov 4, 2025

Summary of changes

Changes introduced in this pull request:

  • update know blocks chceckpoint

Reference issue to close (if applicable)

Closes #6215

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Summary by CodeRabbit

  • Chores
    • Added new epoch-to-header mappings for calibnet and mainnet.
    • Updated introductory header source reference from filfox to berryx.
    • Adjusted checkpoint template resource estimates (download size/time) for calibnet and mainnet.

@akaladarshi akaladarshi requested a review from a team as a code owner November 4, 2025 14:23
@akaladarshi akaladarshi requested review from hanabi1224 and sudo-shashank and removed request for a team November 4, 2025 14:23
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 4, 2025

Walkthrough

Added two checkpoint entries to build/known_blocks.yaml (calibnet epoch 3110397 and mainnet epoch 5443200) and updated download-size/time comment lines in .github/CHECKPOINT_ISSUE_TEMPLATE.md. No code exports or runtime behavior changed.

Changes

Cohort / File(s) Change Summary
Checkpoint mappings
build/known_blocks.yaml
Added calibnet mapping 3110397 → bafy2bzaceb7fz2umktqqckzbygfhcun4avpd6g5pgrmhg4w4rvsuywbbptm6e and mainnet mapping 5443200 → bafy2bzacedisdelql35luibjoxk5jyw7iai5if4eezrjslwhtuqmcczdjahb2. Also updated header source note from filfox to berryx.
Checkpoint issue template
.github/CHECKPOINT_ISSUE_TEMPLATE.md
Updated resource-estimate comment lines for calibnet (approx. ~6G, ~5min) and mainnet (approx. ~74G, ~60mins). No command changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify the two epoch→CID values and formatting in build/known_blocks.yaml.
  • Confirm comment edits in .github/CHECKPOINT_ISSUE_TEMPLATE.md are accurate and consistent.

Possibly related issues

  • #5884 — Related recurring checkpoint workflow and updates to build/known_blocks.yaml.
  • #6016 — Similar edits adding/updating epoch→header mappings in build/known_blocks.yaml.
  • #6127 — Matches same goal of updating checkpoint mappings in build/known_blocks.yaml.

Possibly related PRs

  • #6017 — Modifies build/known_blocks.yaml with new epoch→CID checkpoint mappings for calibnet and mainnet.
  • #5887 — Adds epoch-to-block-header checkpoint mappings in build/known_blocks.yaml.
  • #6163 — Adds new epoch→CID checkpoint mappings to build/known_blocks.yaml.

Suggested reviewers

  • hanabi1224
  • sudo-shashank
  • elmattic

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Out of Scope Changes check ❓ Inconclusive The PR includes a minor update to .github/CHECKPOINT_ISSUE_TEMPLATE.md with updated resource estimates, which is tangentially related but not a core requirement of issue #6215. Clarify whether the template updates are necessary for this maintenance task or should be addressed in a separate PR focused on template maintenance.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: update known blocks' directly corresponds to the main change of adding calibnet and mainnet checkpoint mappings to build/known_blocks.yaml.
Linked Issues check ✅ Passed The PR successfully fulfills the requirement to update build/known_blocks.yaml with new checkpoints for both calibnet and mainnet as specified in issue #6215.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch akaladarshi/update-known-blocks

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b2cc37d and b5135fa.

📒 Files selected for processing (1)
  • .github/CHECKPOINT_ISSUE_TEMPLATE.md (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: hanabi1224
Repo: ChainSafe/forest PR: 6079
File: src/chain_sync/metrics.rs:6-7
Timestamp: 2025-09-16T12:55:26.955Z
Learning: HEAD_EPOCH references in shell scripts (like scripts/tests/calibnet_eth_mapping_check.sh) that extract data from `forest-cli info show` are unrelated to Rust metrics constants with the same name and should not be flagged when metrics cleanup is performed.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: cargo-publish-dry-run
  • GitHub Check: Build Ubuntu
  • GitHub Check: Build MacOS
  • GitHub Check: tests-release
  • GitHub Check: tests
  • GitHub Check: Build forest binaries on Linux AMD64
  • GitHub Check: All lint checks
🔇 Additional comments (1)
.github/CHECKPOINT_ISSUE_TEMPLATE.md (1)

22-23: Verify the updated resource estimates match actual observations.

The calibnet and mainnet download size and time estimates have been increased significantly:

  • Calibnet: 3G→6G (doubled), 1min→5min (5× longer)
  • Mainnet: 60G→74G, 15min→60min (4× longer)

A previous reviewer noted concerns about the math on these estimates. Please confirm that these new numbers accurately reflect the current snapshot sizes and download times you observed when preparing this update. This helps ensure the template provides realistic expectations for future checkpoint update runs.


Comment @coderabbitai help to get the list of available commands and usage tips.

sudo-shashank
sudo-shashank previously approved these changes Nov 4, 2025
@akaladarshi akaladarshi enabled auto-merge November 4, 2025 14:29
#
# This file is maintained monthly - see `CHECKPOINT_ISSUE_TEMPLATE.md`
calibnet:
3110397: bafy2bzaceb7fz2umktqqckzbygfhcun4avpd6g5pgrmhg4w4rvsuywbbptm6e
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be 3110400?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, 3110400 - 3110398 are all null tipsets

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update it again, actually I made these changes in the afternoon, since then it got updated.

The current one is not wrong : https://beryx.io/fil/calibration/block-cid/bafy2bzaceb7fz2umktqqckzbygfhcun4avpd6g5pgrmhg4w4rvsuywbbptm6e

@akaladarshi akaladarshi added this pull request to the merge queue Nov 4, 2025
@akaladarshi akaladarshi removed this pull request from the merge queue due to a manual request Nov 4, 2025
Comment on lines 22 to 23
# - calibnet ~6G, ~5min on a droplet
# - mainnet ~74G, ~20mins on a droplet
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The math doesn't add up really. 😆

@sudo-shashank
Copy link
Contributor

@akaladarshi any updates?

# - calibnet ~3G, ~1min on a droplet
# - mainnet ~60G, ~15mins on a droplet
# - calibnet ~6G, ~5min on a droplet
# - mainnet ~74G, ~60mins on a droplet
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't really my experience, but it doesn't really matter.

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Nov 6, 2025
Merged via the queue into main with commit 17d5ed7 Nov 6, 2025
51 checks passed
@LesnyRumcajs LesnyRumcajs deleted the akaladarshi/update-known-blocks branch November 6, 2025 12:33
@coderabbitai coderabbitai bot mentioned this pull request Jan 7, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cron: update known_blocks.yaml

5 participants