Skip to content

fix: reflect reality with Curio #6223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LesnyRumcajs merged 1 commit into from
Nov 3, 2025
Merged

fix: reflect reality with Curio #6223

LesnyRumcajs merged 1 commit into from
Nov 3, 2025

Conversation

@LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Nov 3, 2025 •
edited by coderabbitai bot
Loading

Summary of changes

Changes introduced in this pull request:

  • don't sell false hopes. It's not on our roadmap for the near future under current team's capacity.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Summary by CodeRabbit

  • Documentation
    • Updated Curio compatibility guidance to clarify that integration with Forest is not yet confirmed.

@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner November 3, 2025 14:07
@LesnyRumcajs LesnyRumcajs requested review from akaladarshi and sudo-shashank and removed request for a team November 3, 2025 14:07
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 3, 2025 •
edited
Loading

Walkthrough

Documentation update to the Curio running guide clarifying that Curio's compatibility with Forest is not yet confirmed, removing references to ongoing compatibility work and a "Coming soon" statement.

Changes

Cohort / File(s) Summary
Documentation Update
docs/docs/users/guides/running_with_curio.md		 Updated note content to indicate Curio-Forest compatibility is not yet confirmed; removed "Coming soon!™" line

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Documentation-only change with no code modifications
  • Simple content rewrite for clarity

Suggested reviewers

  • akaladarshi
  • sudo-shashank

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title 'fix: reflect reality with Curio' directly aligns with the main change in the changeset. The PR updates documentation in the Curio guide to reflect that compatibility is not yet confirmed and removes misleading 'Coming soon' messaging, which accurately represents correcting documentation to reflect current reality. The title is concise, specific, and clearly conveys the primary intent of the change.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch curio-later
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between efc9068 and 2f0b7bc.

📒 Files selected for processing (1)
  • docs/docs/users/guides/running_with_curio.md (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings 
Learnt from: LesnyRumcajs
Repo: ChainSafe/forest PR: 5907
File: src/rpc/methods/state.rs:523-570
Timestamp: 2025-08-06T15:44:33.467Z
Learning: LesnyRumcajs prefers to rely on BufWriter's Drop implementation for automatic flushing rather than explicit flush() calls in Forest codebase.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Check
  • GitHub Check: Deploy to Cloudflare Pages
🔇 Additional comments (1)
docs/docs/users/guides/running_with_curio.md (1)

8-8: ✓ Clear and realistic status update.

The revised note effectively removes misleading language ("Coming soon!™" and references to ongoing compatibility work) and replaces it with a factual statement that sets appropriate expectations. This aligns well with the PR objective to avoid selling false hopes and reflects the team's current capacity constraints.

Comment @coderabbitai help to get the list of available commands and usage tips.

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Nov 3, 2025
Merged via the queue into main with commit eb8c0d6 Nov 3, 2025
20 checks passed
@LesnyRumcajs LesnyRumcajs deleted the curio-later branch November 3, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akaladarshi akaladarshi akaladarshi approved these changes

@sudo-shashank sudo-shashank Awaiting requested review from sudo-shashank sudo-shashank is a code owner automatically assigned from ChainSafe/forest

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LesnyRumcajs @akaladarshi