Skip to content

chore: add debugging profile to Cargo.toml #6184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LesnyRumcajs merged 1 commit into from
Oct 23, 2025
Merged

chore: add debugging profile to Cargo.toml #6184

LesnyRumcajs merged 1 commit into from
Oct 23, 2025

Conversation

@LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Oct 23, 2025 •
edited by coderabbitai bot
Loading

Summary of changes

Changes introduced in this pull request:

  • I had to do some interactive debugging recently; this profile helped me a bit. It's more sustainable than constantly editing the dev profile.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Summary by CodeRabbit

  • Chores
    • Updated debugging profile configuration in build settings with enhanced debug symbol handling for improved development builds.

@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner October 23, 2025 11:12
@LesnyRumcajs LesnyRumcajs requested review from akaladarshi and elmattic and removed request for a team October 23, 2025 11:12
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 23, 2025 •
edited
Loading

Walkthrough

A new Cargo profile named "debugging" is added, configured to inherit from the dev profile with debug symbols set to full and split-debuginfo disabled. This profile supports LLDB debugging and Go FFI builds.

Changes

Cohort / File(s) Change Summary
Build Configuration
Cargo.toml		 Adds new [profile.debugging] section inheriting from dev profile with debug = "full" and split-debuginfo = "off" settings to enable debugging support.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "chore: add debugging profile to Cargo.toml" is fully aligned with the changes in the pull request. The changeset adds a new debugging profile to Cargo.toml with specific configuration settings (inheriting from dev, debug level set to full, and split-debuginfo set to off), which is exactly what the title describes. The title is concise, clear, and uses appropriate conventional commit formatting. It effectively communicates the primary change without unnecessary detail or vague terminology.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch debugging-profile
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 23bbf73 and a553a2d.

📒 Files selected for processing (1)
  • Cargo.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: tests
  • GitHub Check: tests-release
  • GitHub Check: Build forest binaries on Linux AMD64
  • GitHub Check: Build Ubuntu
  • GitHub Check: cargo-publish-dry-run
  • GitHub Check: Build MacOS
  • GitHub Check: All lint checks
🔇 Additional comments (1)
Cargo.toml (1)

272-278: Well-documented debugging profile addition.

The new [profile.debugging] configuration is correctly formatted and well-suited for its stated purpose. The comments appropriately document the LLDB use case, cross-platform considerations, and Go FFI limitations with clear guidance for users.

Comment @coderabbitai help to get the list of available commands and usage tips.

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Oct 23, 2025
Merged via the queue into main with commit 863fe34 Oct 23, 2025
40 checks passed
@LesnyRumcajs LesnyRumcajs deleted the debugging-profile branch October 23, 2025 12:14
@coderabbitai coderabbitai bot mentioned this pull request Dec 16, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hanabi1224 hanabi1224 hanabi1224 approved these changes

@akaladarshi akaladarshi akaladarshi approved these changes

@elmattic elmattic Awaiting requested review from elmattic elmattic is a code owner automatically assigned from ChainSafe/forest

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LesnyRumcajs @hanabi1224 @akaladarshi